Raw values #18
Merged
Raw values #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions of the temperature and humidity. Computation of the actual values now happens in `getHumidity()` and `getTemperature()`. Additionally, `getRawHumidity()` and `getRawTemperature()` will return the raw two-byte representations. Bumped the version to 0.3.2.
|
Did a quick review and it all looks pretty straightforward. Thanks |
|
Looks like the tests failed since now the initial value for BTW, do you want me to add some tests for the raw values? It didn't occur to me before, but I'd be happy to do it. |
|
You broke the unit tests - no big problem. update: fix is under test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the comments in issue #17, here's a PR for exposing the raw two-byte humidity and temperature values.
I think I've followed all your suggestions, but if I messed up or misinterpreted, just let me know! I'm happy to fix it so it matches what you want. :-)
The only question I have is: since this is making a significant-yet-backwards-compatible change, maybe the new version should be 0.4.0 instead of 0.3.2? I'll defer to whatever you prefer--just thought I'd ask.