-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/add qoc config #62
Conversation
Codecov ReportBase: 97.50% // Head: 97.50% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage 97.50% 97.50%
=======================================
Files 5 5
Lines 160 160
=======================================
Hits 156 156
Misses 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for the PR.
I see ruff
got busy with all those changes, it is a cool tool. There is one case I have to double-check: I see that ruff
removes unused variables, which makes sense. However, I have to double-check the case of pynteny = Pynteny(...)
, I think it was there to prevent unwanted text from being prompted.
@Robaina This PR adds a bit of noise across the files, with what could be perceived as changes without much value. The same applies to the import sorting, now that they are sorted, it will be easier to spot the changes in the organized sections:
|
Right, I understand and agree on the benefits of using these tools. Nice tools! As I wrote before, I'm thinking of integrating the linting within the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving merge
This PR adds a few quality of code tools to help with long-term maintenance.
`ruff .`
The two "bare except" errors are silenced using
Exception
. This is only a bit better than bare except (I will not bore you with the details, but bare except catches stuff like SIGINT signal with Ctrl + C, whereasException
is the superclass of all user-defined exceptions)