Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile and debottleneck validation #19

Open
Robbybp opened this issue Mar 28, 2024 · 0 comments
Open

Profile and debottleneck validation #19

Robbybp opened this issue Mar 28, 2024 · 0 comments

Comments

@Robbybp
Copy link
Owner

Robbybp commented Mar 28, 2024

With recent performance improvements in solve_strongly_connected_components, this is no longer the bottleneck in data-validation, especially if Pyomo/pyomo#3190 is used. However, validating a single set of inputs is still slower than I would like. I see the following runtime breakdown:

Identifier   ncalls   cumtime   percall      %
----------------------------------------------
make-model        1     2.267     2.267   17.3
post-solve        1     0.411     0.411    3.1
solve-scc         1     2.062     2.062   15.7
validate          1     8.374     8.374   63.9
==============================================

Validation is quite a bit slower than I would expect, and I suspect this is because we're not exploiting named expressions when evaluating expression in Pyomo. We should confirm this, then possibly try to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant