Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/redesign #4

Merged
merged 9 commits into from
Jun 4, 2020
Merged

Feature/redesign #4

merged 9 commits into from
Jun 4, 2020

Conversation

RobinKa
Copy link
Owner

@RobinKa RobinKa commented Jun 4, 2020

  • Remove original MultiVector class and use bare tf.Tensor instances and functions on them instead
  • Use dense representation instead of sparse with blade indices
  • Add new MultiVector class that just wraps those functions, operates on MultiVector instances and exposes less verbose operators (eg. ~ for reversion as before)

Advantages:

  • Dense is faster (STA MV*MV roughly 50x speedup on GPU)
  • No tf.Tensor * MultiVector issues (because tf.Tensor's __mul__ doesn't raise NotImplemented)
  • Can easily use tensorflow functions etc.
  • Easier implementation (no thinking about blade indices required anymore)

Disadvantages:

  • Might be confusing having both the bare tf.Tensor representation and the MultiVector wrapper
  • Sparse representation might still be faster on CPU, and uses less memory

@RobinKa RobinKa merged commit 25cfaab into master Jun 4, 2020
@RobinKa RobinKa deleted the feature/redesign branch June 4, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants