v18 is for Victoria
#1639
Merged
v18 is for Victoria
#1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinTail
added
documentation
The idea here is to make the Quick Start with Express Zod API even faster by making a basic console logger detached from Winston. ### Benefits - Reducing peer dependencies (easier installation command), - Reducing confusion (reasons for installing winston in the fast track), - No need for declaring `LoggerOverrides` in the Quick Start section (easier documentation for beginners), - Simpler implementation. ### Caveats - Breaking changes to the publicly exposed method `createLogger` (removing `winston` prop from its argument), - No advanced features like child logger and profiling by default — that would require user to configure a custom logger, - ~~Need `chalk` as production dependency,~~ - ~~However: Can colorize logo in runtime (no assuming colors).~~
Some terminals may not support colors and I'd like to avoid assumptions on that issue. I tried several libraries, but in the end Chalk is the most reliable one, because it has fallbacks. Using latest Chalk v5 (which is ESM only) requires to make `createLogger()` fn async.
- it's faster - it supports CJS - it has named exports - Similar to Chalk it now supports fallbacks from True Color Related topic: webdiscus/ansis#18
In v18 after detaching from winston, certain entities can be made sync again.
|
QA passed in general, but a minor thing I'd like to fix is color detection of |
|
QA passed ✅ |
RobinTail
commented
Apr 20, 2024
RobinTail
commented
Apr 20, 2024
RobinTail
commented
Apr 20, 2024
RobinTail
commented
Apr 20, 2024
RobinTail
commented
Apr 20, 2024
RobinTail
commented
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dedication
Victoria Carmen White, a black trans woman, was murdered in New Jersey, US, on 12 September 2010. Her boyfriend was brought to trial for her death, but he was acquitted and blamed another man for the murder. The gun used in the killing was never found.
Transgender women suffer too frequently from transphobic violence and cruelty, being the less protected social group. I'd like to raise an awareness of this problem. Humans should be creators — not killers. But most importantly, I want every transgender girl to have an opportunity to create applications quickly and, in general, learn to write code easily in order to receive job offers and leave dangerously transphobic territories for more favorable and civilized ones, and live happily there. Protect transgender women.
Version 18
Description
This version is focused on making the quick start with Express Zod API even faster by replacing Winston with a built-in console logger having the same basic functionality needed to begin the development. Migration should be easy in most cases.
What's included
chalkin runtime #1640, later overridden by:attachRouting()in v18 #1671