Ref: disabling dynamic imports in CJS build #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinTail
added
refactoring
RobinTail
added a commit
that referenced
this pull request
May 12, 2024
Still has issues with dynamic imports (disabled for CJS in #1757 ) More details on that issue I posted in evanw/esbuild#2651 (comment) Article on exact issue: https://nodejs.org/api/vm.html#support-of-dynamic-import-in-compilation-apis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a Jest issue on handling dynamic imports that is really annoying.
I used to apply an approach discussed in this issue:
evanw/esbuild#2651
But now I'm going to apply another approach from the same one, just by disabling the dynamic imports for CJS, as a cleaner way (in my opinion).
https://esbuild.github.io/api/#supported