Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing defaults for BuiltinLogger #1821

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Fix missing defaults for BuiltinLogger #1821

merged 3 commits into from
Jun 6, 2024

Conversation

RobinTail
Copy link
Owner

Defaults lost in development of 19.2.0

@RobinTail RobinTail added the bug Something isn't working label Jun 6, 2024
@coveralls-official Coveralls Official
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 2e3b0ae on fix-defaults-for-builtin-logger
into 2cf7ba8 on master.

@coveralls-official Coveralls Official
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 5cc15aa on fix-defaults-for-builtin-logger
into 2cf7ba8 on master.

@RobinTail RobinTail marked this pull request as ready for review June 6, 2024 12:57
RobinTail
RobinTail commented Jun 6, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail merged commit 66e5941 into master Jun 6, 2024
11 checks passed
@RobinTail RobinTail deleted the fix-defaults-for-builtin-logger branch June 6, 2024 13:03
@coveralls-official Coveralls Official
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 030ed4f on fix-defaults-for-builtin-logger
into 2cf7ba8 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail