This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7 (for the new reconciler).
I started from the
new-reconciler-fragments
branch that @LPGhatguy made and finished repairing/adding tests and patching inconsistencies.One thing that fell out of this change was the need to distinguish between these two scenarios:
RobloxRenderer
to process the children of host nodes, and also the reconciler itself to process children specified viaRoact.Children
.Component
with its lifecycle methods, and also by the reconciler itself to mount/update function components.Right now, I'm enforcing the above rules with two different reconciler functions for updating a node's children.
Checklist before submitting:
CHANGELOG.md