This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Change misleading code in Roact.Change example #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetPropertyChangedSignal does not pass the new value of the property to the function and the Roact.Change handler doesn't add this functionality so the current example code is slightly misleading.
|
Cool, thanks for the doc fix! |
LPGhatguy
approved these changes
May 2, 2019
ZoteTheMighty
added a commit
that referenced
this pull request
May 3, 2019
* Remove references to 'primitive' components/elements * Adjust some wording around kinds of components, fix broken link * functional component -> function component * Avoid usage of the verb 'reconcile' where not directly applicable * Deprecate Roact.reconcile in favor of Roact.update in master (#194) * Update CHANGELOG * Remove undocumented APIs `getGlobalConfigValue` and `Element` (#195) * Roact.reconcile replaced with Roact.update, uses of reconcile changed to update. Occasional mentions of 'the Roact reconciler' have been changed to simply 'Roact' * Add version info to new apis, more details to validateProps, added section for setGlobalConfig * Added the 'enable tracebacks' message to other places that try to use element tracebacks * Change misleading code in Roact.Change example (#196) * PR comments: mention deprecated names, fix links * Rename propertyValidation config key to propValidation, add code snippet for enabling it to docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetPropertyChangedSignal does not pass the new value of the property to the function and the Roact.Change handler doesn't add this functionality so the current example code is slightly misleading.