-
Notifications
You must be signed in to change notification settings - Fork 142
Enforce code style and linting to eliminate Studio indentation warnings #321
Conversation
…g string>', arg1, arg) where it inlines an existing statement that's well-formatted that may make this a no-go until stylua fixes the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you doublecheck this in Studio and make sure this eliminates the warning, and doesn't introduce any others? StyLua and Selene may not share the same expectations as the script analyzer
… and nonstrict analysis. I think this is good enough for now.
Verified, and went a little further to pin a few files as strict/nonstrict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Took a closer look and it seems like you made changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor Pickup from me.
Not sure how that happened. Let me try reverting that. |
Supercedes PR #313 .
Rather than spot fix one styling issue, let's mistake-proof it.
Checklist before submitting:
CI-only and non-functional, so no CHANGELOG or test updates needed