Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Enforce code style and linting to eliminate Studio indentation warnings #321

Merged
merged 18 commits into from
Sep 25, 2021

Conversation

matthargett
Copy link
Contributor

@matthargett matthargett commented Sep 17, 2021

Supercedes PR #313 .

Rather than spot fix one styling issue, let's mistake-proof it.

Checklist before submitting:
CI-only and non-functional, so no CHANGELOG or test updates needed

* [ ] Added entry to `CHANGELOG.md`
* [ ] Added/updated relevant tests
  • Added/updated documentation

Copy link
Contributor

@ZoteTheMighty ZoteTheMighty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you doublecheck this in Studio and make sure this eliminates the warning, and doesn't introduce any others? StyLua and Selene may not share the same expectations as the script analyzer

selene.toml Outdated Show resolved Hide resolved
@matthargett
Copy link
Contributor Author

Can you doublecheck this in Studio and make sure this eliminates the warning, and doesn't introduce any others? StyLua and Selene may not share the same expectations as the script analyzer

Verified, and went a little further to pin a few files as strict/nonstrict.

Copy link
Contributor

@ZoteTheMighty ZoteTheMighty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ZoteTheMighty
Copy link
Contributor

Took a closer look and it seems like you made changes to the testez submodule, any reason?

Copy link

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Pickup from me.

.github/workflows/ci.yml Show resolved Hide resolved
@matthargett
Copy link
Contributor Author

Took a closer look and it seems like you made changes to the testez submodule, any reason?

Not sure how that happened. Let me try reverting that.

@coveralls
Copy link

coveralls commented Sep 25, 2021

Coverage Status

Coverage increased (+0.02%) to 94.802% when pulling bf2246c on stylua into 103bd18 on master.

@matthargett matthargett merged commit b2ba9cf into master Sep 25, 2021
@matthargett matthargett deleted the stylua branch September 25, 2021 00:23
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants