-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs - 12-prices.md #276
Conversation
I have roughly tried to jot down what goes according to what I understood (@Reckless-Satoshi please correct me if I got something wrong). You can include this in the docs by making them a little more readable/presentable.
|
Hey Okada, this PR reads just perfect. It looks good to be merged. 🚀 Indeed, I had in mind to add a small explanation on how the fees are deducted. Possibly best to leave it for We should aim to use global variables for all of the hardcoded values as often as possible. These variables are set in New variables can be created any time. These can be used in any markdown file by simply typing You can see an example of how many of these variables are used in the "how to guide" https://github.com/Reckless-Satoshi/robosats/blob/main/docs/_pages/tutorials/read/how-to-use.md Please submit an invoice for 20K from a proxy wallet as usual 😄 |
2b1a120
to
c2fb0e2
Compare
Update to include "Prices in Practice" section
Heh, better later than never, I suppose! lnbc200u1p3h4dvcpp5ws3fgglj03c7cs5pd6l3erynrwmzgl0krlajejvng325zfjtlmgqdqu2askcmr9wssx7e3q2dshgmmndp5scqzpgxqyz5vqsp5e6hmx28n5paxnxnq2l9k55g97hdgwupna54fqgmfqg45nq2qzceq9qyyssqx8wsxwfc2efq7px7dhvr789jnhd6ag9vm9nmmydwt5v8k8g7mepjtxgcqj7ys0h76lhzfee03demc58l745t8k9stkkqqj3a83hsnlsqh6gg8x I've updated the PR with the requested changes. Please review and double check my verbiage! Great job @redphix for the breakdown, I'll look to do that more often and encourage more comments! Makes the explanation 10x clearer. And I'll work to update the other docs with the _config.yml information |
eec0685d7097ff1727bb821210844e9993db928afe0e4c58fe016c8355bde450 Great work! Merging! |
What does this PR do?
Update Learn RoboSats documentation for "Prices"
Checklist before merging
cd frontend; npm run format
. If it's a mobile app feature I rancd mobile; npm run format
.I noticed the "<!-- Cover>" verbiage, How should I expand on this item: "...how trade_amount sats is converted into payout_amount and escrow_amount applying the fee factors"?