Annoy black

[redphix]

What does this PR do?

annoy black

Checklist before merging

• If it's a frontend feature, I have ran prettier cd frontend; npm run format. If it's a mobile app feature I ran cd mobile; npm run format.

[redphix]

Okay nice. The flake8 lints work with annotations.

[redphix]

@Reckless-Satoshi
But the black auto-fix should only work when you either

1. Open a PR yourself
2. push to main

looks fine for now. What do you think?

The reason you don't see black annotating the commits is that they get fixed due to auto_fix so the action assumes that you don't want to annotate the commits and just fix them. Looks alright to me. The annotations that black displays aren't really lint errors, but diffs -- it tells you what to delete/add to conform to black style guide, which I don't find that user friendly. It's a diff, which indicates just let it do its thing and auto apply it.

[Reckless-Satoshi]

looks fine for now. What do you think?

I think it's a way better set up than what we had before! 😄 Thank you very much for getting this done 🚀

[redphix]

Final test I guess -- merging this should run the auto-fix and commit it to main branch.

[Reckless-Satoshi]

Final test I guess -- merging this should run the auto-fix and commit it to main branch.

Merged. Auto-fix did not add a new commit, possibly because it also needs on.pull_request event as trigger. In any case, do we want auto fix commits? It is probably enough with PR checks. Also a bit scary the bot committing changes to main :D

[redphix]

@Reckless-Satoshi Yes, I was also having second thoughts about it :D. A bot commit changes to main is definitely an uncomfortable feeling. I guess we don't autofix then -- commit annotations are more than enough. The auto-fixing part can be documented/enforced using pre-commit, but again, it just formatting, so don't think it's that serious - on the fence with this..you decide xD

[redphix]

@Reckless-Satoshi Oh the reason It didn't auto-fix is because of this - https://github.com/redphix/robosats/blob/1dea4e73b6410ca741c85a4b6c4b8ab2e2649bcb/.github/workflows/py-linter.yml#L36