Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically label PRs whose CI results are too stale #9469

Closed
jwnimmer-tri opened this issue Sep 18, 2018 · 5 comments
Closed

Automatically label PRs whose CI results are too stale #9469

jwnimmer-tri opened this issue Sep 18, 2018 · 5 comments
Assignees
Labels

Comments

@jwnimmer-tri
Copy link
Collaborator

To prevent problems like #9468 (and a few other recent instances like it), we would like to prevent merging PRs when their CI results are too stale -- where master has evolved out from underneath them.

We'd like to automatically label PRs whose CI results are too stale -- then we can have Reviewable prevent their merging. (Or maybe the status / label could be just like any other status-check.)

As a start, CI results older than a couple days could be highlighted. You could imagine more imaginative checks, that looks at how much has been merged, or if related packages were touched (even a few minutes ago).

(Discussed in #platform_review slack.)

Over to @EricCousineau-TRI for prioritization.
\CC @jamiesnape

@jamiesnape
Copy link
Contributor

Also relates #10582.

@jamiesnape
Copy link
Contributor

I would probably promote this to medium (and you can assign it to me).

@jwnimmer-tri jwnimmer-tri added the component: continuous integration Jenkins, CDash, mirroring of externals, website infrastructure label Apr 28, 2020
@jwnimmer-tri
Copy link
Collaborator Author

jwnimmer-tri commented Dec 10, 2020

I wonder if https://github.com/apps/stale would be able to implement this? It's been on my wishlist to push forward setting up to automatically close out stale pull requests (those without activity for >6 months). Maybe two birds with one stone.

@jwnimmer-tri
Copy link
Collaborator Author

RobotLocomotion/drake-external-examples#201 is a tryout in drake-external-examples.

@jwnimmer-tri
Copy link
Collaborator Author

We have not had very many stale-merge-race failures recently. We can re-open this if we start to see them again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants