New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py math: Support pickling #11976
py math: Support pickling #11976
Conversation
This enusres `pickle` can refer to the instantiations
8fbc73c
to
5f51039
Compare
py autodiff: Add pickle support
5f51039
to
3b55984
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@sammy-tri Might you be up for doing feature review on this?
Reviewable status: LGTM missing from assignee sammy-tri(platform), needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @sammy-tri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@ggould-tri for platform review
Reviewed 11 of 11 files at r1.
Reviewable status: LGTM missing from assignee ggould-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @ggould-tri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 11 files at r1.
Reviewable status: 2 unresolved discussions, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @EricCousineau-TRI)
bindings/pydrake/common/eigen_geometry_py.cc, line 301 at r1 (raw file):
DefCast<T>(&cls, kCastDoc); DefPickle(&cls, // Use Python methods to use `wxyz` form.
minor: Grammar? "use ... to use"
bindings/pydrake/common/test/cpp_template_test.py, line 43 at r1 (raw file):
def check_pickle(test, obj):
minor: Rule-of-three on this code, which is copypasta'd with small differences several times in this PR.
However this is test code so if it's impractical to factor you can dismiss this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will file minor follow-up PR with the fixes - thanks!
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
Resolves #11957
This change is