Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py math: Support pickling #11976

Merged

Conversation

EricCousineau-TRI
Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI commented Aug 28, 2019

Resolves #11957


This change is Reviewable

This enusres `pickle` can refer to the instantiations
Copy link
Contributor Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@sammy-tri Might you be up for doing feature review on this?

Reviewable status: LGTM missing from assignee sammy-tri(platform), needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @sammy-tri)

Copy link
Contributor

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: +@ggould-tri for platform review

Reviewed 11 of 11 files at r1.
Reviewable status: LGTM missing from assignee ggould-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @ggould-tri)

Copy link
Contributor

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 11 files at r1.
Reviewable status: 2 unresolved discussions, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @EricCousineau-TRI)


bindings/pydrake/common/eigen_geometry_py.cc, line 301 at r1 (raw file):

    DefCast<T>(&cls, kCastDoc);
    DefPickle(&cls,
        // Use Python methods to use `wxyz` form.

minor: Grammar? "use ... to use"


bindings/pydrake/common/test/cpp_template_test.py, line 43 at r1 (raw file):

def check_pickle(test, obj):

minor: Rule-of-three on this code, which is copypasta'd with small differences several times in this PR.

However this is test code so if it's impractical to factor you can dismiss this comment.

Copy link
Contributor Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will file minor follow-up PR with the fixes - thanks!

Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)

@EricCousineau-TRI EricCousineau-TRI added the status: commits are properly curated https://drake.mit.edu/reviewable.html#curated-commits label Aug 29, 2019
@EricCousineau-TRI EricCousineau-TRI merged commit e3b81a9 into RobotLocomotion:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: commits are properly curated https://drake.mit.edu/reviewable.html#curated-commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

py math: Should support pickling
3 participants