lint: Ignore bazel-kcov artifacts in find_all_sources #12385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: medium
status: single reviewer ok
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: needs platform reviewer assigned, needs at least one assigned reviewer
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI(platform)
jwnimmer-tri
force-pushed
the
find_all_sources-tidy
branch
from
caa6a12
to
2344c2c
Compare
|
I realized this would break non-Drake non-Anzu projects (those who have a source tree without 5000 files in it), so I reverted the length checks to stay in the unit test for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves on #12369.
Tested locally via:
This change is