common: Remove deprecated text_logging_gflags #12680
Conversation
|
+@jamiesnape for feature review, please. |
|
@drake-jenkins-bot linux-bionic-unprovisioned-gcc-bazel-experimental-release please |
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge"
common/BUILD.bazel, line 481 at r1 (raw file):
) # XXX
BTW Remove/replace?
This means that the gflags header is no longer used by the drake install; only libgflags.so is required. Accordingly, we can adjust the source vs binary deps and remove CMake infrastructure related to gflags.
jwnimmer-tri
force-pushed
the
deprecation-2020-02-gflags
branch
from
8738408
to
01644c9
Compare
There was a problem hiding this comment.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @jamiesnape)
common/BUILD.bazel, line 481 at r1 (raw file):
Previously, jamiesnape (Jamie Snape) wrote…
BTW Remove/replace?
Done.
|
+@ggould-tri for platform review per schedule, please. |
There was a problem hiding this comment.
Reviewed 7 of 8 files at r1, 1 of 1 files at r2.
Reviewable status:complete! all discussions resolved, LGTM from assignees ggould-tri(platform),jamiesnape
This means that the gflags header is no longer used by the drake install; only libgflags.so is required. Accordingly, we can adjust the source vs binary deps and remove CMake infrastructure related to gflags.
Follow-up from #12287.
This change is