tools: Change order of third-party includes #13286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: high
status: do not merge
status: do not review
and removed
status: do not review
labels
|
+@sammy-tri for both reviews per schedule, please. Note that r_base..r_1 is already reviewed in #13259. Only review r1_..tip in this PR. (I'll rebase the first commit away after that PR merges.) |
jwnimmer-tri
added
the
status: single reviewer ok
The new clang-format-9 prefers quote includes before angle includes. To use a different order, we'd have to insert an empty line between them, and we don't want to do that. So, we'll relent and allow the quote includes to appear first.
jwnimmer-tri
force-pushed
the
clang-format-includes-quote-angle
branch
from
6295c02
to
c5cc77c
Compare
|
(Rebase is complete.) |
sammy-tri
reviewed
May 12, 2020
There was a problem hiding this comment.
I think I hate how this looks, but I can't think of a version of mixing quote and angle includes in the same section which I'd like, and the style guide says "accept whatever clang-format enforces" so, eh
Reviewed 38 of 38 files at r2.
Reviewable status:complete! all discussions resolved, LGTM from assignee sammy-tri(platform)
|
Skipping everything / lsan / debug builds for trivial change. Forcing in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #13236. Requires #13259.
The new clang-format-9 prefers quote includes before angle includes. To use a different order, we'd have to insert an empty line between them, and we don't want to do that. So, we'll relent and allow the quote includes to appear first.
This change is