New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sphinx-doc@1.8 from Homebrew instead of Sphinx and sphinx_rtd_theme from PyPI #13551
Conversation
@drake-jenkins-bot mac-mojave-unprovisioned-clang-bazel-experimental-release please |
So we are not even using the executable found by |
@drake-jenkins-bot mac-mojave-unprovisioned-clang-bazel-experimental-release please |
+@jwnimmer-tri for feature review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@soonho-tri for user testing, please.
Reviewed 6 of 6 files at r1.
Reviewable status: LGTM missing from assignees jwnimmer-tri(platform),soonho-tri(platform), labeled "do not merge" (waiting on @soonho-tri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following works on my macs:
./setup/mac/install_prereqs.sh
bazel run //doc:serve_sphinx
Now macsim
has robotlocomotion/director/sphinx-doc@1.8
installed.
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), labeled "do not merge" (waiting on @soonho-tri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@ggould-tri for platform review per schedule, please.
Reviewable status: LGTM missing from assignee ggould-tri(platform), labeled "do not merge" (waiting on @ggould-tri and @soonho-tri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1.
Reviewable status: labeled "do not merge" (waiting on @soonho-tri)
Closes #13529.
This change is