Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid geometry from the jaco model #14042

Merged
merged 1 commit into from Sep 10, 2020

Conversation

ggould-tri
Copy link
Contributor

@ggould-tri ggould-tri commented Sep 10, 2020

An upcoming PR will mention this model in a data= line, which will
cause it to be validity checked.


This change is Reviewable

An upcoming PR will mention this model in a `data=` line, which will
cause it to be validity checked.
Copy link
Contributor Author

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@EricCousineau-TRI per #14038

Reviewable status: LGTM missing from assignee EricCousineau-TRI(platform), needs at least two assigned reviewers (waiting on @EricCousineau-TRI)

@EricCousineau-TRI EricCousineau-TRI added the status: single reviewer ok https://drake.mit.edu/reviewable.html label Sep 10, 2020
Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: +(status: single reviewer ok)

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee EricCousineau-TRI(platform)


manipulation/models/jaco_description/urdf/j2n6s300.urdf, line 42 at r1 (raw file):

   finger_distal      58
-->
  <!-- Director seems to really want a link named "base", so this is

BTW Yuck?

Copy link
Contributor Author

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee EricCousineau-TRI(platform)


manipulation/models/jaco_description/urdf/j2n6s300.urdf, line 42 at r1 (raw file):

Previously, EricCousineau-TRI (Eric Cousineau) wrote…

BTW Yuck?

You're not wrong.

@ggould-tri ggould-tri merged commit 8756a70 into RobotLocomotion:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants