New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move acrobot monte carlo simulation out of dev #14522
Move acrobot monte carlo simulation out of dev #14522
Conversation
a discussion (no related file): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+(priority: low) +(type: feature request) +(type: TRI anzu wishlist)
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@rpoyner-tri for feature review (last person to touch this directory not involved in writing this code)
Note: This code is moving out of dev and has not had Drake review; please expand and review each moved (non-BUILD) file as-new.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform), needs at least two assigned reviewers (waiting on @rpoyner-tri)
With the new stuff coming in, I'd like to advocate for a |
For informational purposes, you can be informed by https://github.com/ggould-tri/drake/blob/acrobot_monte_carlo_dedev_2/examples/acrobot/README.md as a draft README. That README is long enough that I don't want to include in this PR, and also it needs a bit more polish. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1.
Reviewable status: LGTM missing from assignee sammy-tri(platform) (waiting on @sammy-tri)
9657169
to
06ade9e
Compare
* Toward RobotLocomotion#13904 * This is the infrastructure to run monte carlo simulations of the acrobot under Spong control. * This is an example of how to use the stochastic schema mechanism for monte carlo testing * A subsequent PR will bring in an example of using this along with an optimizer to learn controller parameters (that code remains in dev in this PR)
06ade9e
to
dc8c2fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making super-slow progress on this due to higher priority items being added to my queue today. Will resume tomorrow if I don't manage to finish tonight.
Reviewed 4 of 10 files at r1.
Reviewable status: LGTM missing from assignee sammy-tri(platform) (waiting on @rpoyner-tri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: LGTM missing from assignee sammy-tri(platform)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries; that's why I marked it low priority :-)
Reviewable status: LGTM missing from assignee sammy-tri(platform)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 10 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),sammy-tri(platform)
* Toward RobotLocomotion#13904 * This is the infrastructure to run monte carlo simulations of the acrobot under Spong control. * This is an example of how to use the stochastic schema mechanism for monte carlo testing * A subsequent PR will bring in an example of using this along with an optimizer to learn controller parameters (that code remains in dev in this PR)
of the acrobot under Spong control.
mechanism for monte carlo testing
with an optimizer to learn controller parameters (that code
remains in dev in this PR)
This change is