Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move acrobot monte carlo simulation out of dev #14522

Merged

Conversation

ggould-tri
Copy link
Contributor

@ggould-tri ggould-tri commented Jan 12, 2021

  • Toward Acrobot monte carlo moved out of dev #13904
  • This is the infrastructure to run monte carlo simulations
    of the acrobot under Spong control.
  • This is an example of how to use the stochastic schema
    mechanism for monte carlo testing
  • A subsequent PR will bring in an example of using this along
    with an optimizer to learn controller parameters (that code
    remains in dev in this PR)

This change is Reviewable

@ggould-tri
Copy link
Contributor Author

a discussion (no related file):
(test message to debug reviewable issue)


@ggould-tri ggould-tri added priority: low type: feature request type: TRI anzu wishlist TRI-internal software potentially available to open-source labels Jan 12, 2021
Copy link
Contributor Author

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+(priority: low) +(type: feature request) +(type: TRI anzu wishlist)

Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers

Copy link
Contributor Author

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@rpoyner-tri for feature review (last person to touch this directory not involved in writing this code)

Note: This code is moving out of dev and has not had Drake review; please expand and review each moved (non-BUILD) file as-new.

Reviewable status: LGTM missing from assignee rpoyner-tri(platform), needs at least two assigned reviewers (waiting on @rpoyner-tri)

@jwnimmer-tri
Copy link
Collaborator

With the new stuff coming in, I'd like to advocate for a README.md in this folder that explains how to browse and run what's available. It used to be fairly homogeneous, but is no longer so.

@ggould-tri
Copy link
Contributor Author

For informational purposes, you can be informed by https://github.com/ggould-tri/drake/blob/acrobot_monte_carlo_dedev_2/examples/acrobot/README.md as a draft README. That README is long enough that I don't want to include in this PR, and also it needs a bit more polish.

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

+@sammy-tri for platform Wednesday schedule.

Reviewed 10 of 10 files at r1.
Reviewable status: LGTM missing from assignee sammy-tri(platform) (waiting on @sammy-tri)

 * Toward RobotLocomotion#13904
 * This is the infrastructure to run monte carlo simulations
   of the acrobot under Spong control.
 * This is an example of how to use the stochastic schema
   mechanism for monte carlo testing
 * A subsequent PR will bring in an example of using this along
   with an optimizer to learn controller parameters (that code
   remains in dev in this PR)
Copy link
Contributor

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making super-slow progress on this due to higher priority items being added to my queue today. Will resume tomorrow if I don't manage to finish tonight.

Reviewed 4 of 10 files at r1.
Reviewable status: LGTM missing from assignee sammy-tri(platform) (waiting on @rpoyner-tri)

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: LGTM missing from assignee sammy-tri(platform)

Copy link
Contributor Author

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries; that's why I marked it low priority :-)

Reviewable status: LGTM missing from assignee sammy-tri(platform)

Copy link
Contributor

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 10 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),sammy-tri(platform)

@sammy-tri sammy-tri merged commit 62feee8 into RobotLocomotion:master Jan 14, 2021
josephsnyder pushed a commit to EricCousineau-TRI/drake that referenced this pull request Mar 16, 2021
* Toward RobotLocomotion#13904
 * This is the infrastructure to run monte carlo simulations
   of the acrobot under Spong control.
 * This is an example of how to use the stochastic schema
   mechanism for monte carlo testing
 * A subsequent PR will bring in an example of using this along
   with an optimizer to learn controller parameters (that code
   remains in dev in this PR)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low type: feature request type: TRI anzu wishlist TRI-internal software potentially available to open-source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants