Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for new macOS versioning scheme and sync minimum compiler and CMake versions for macOS #14608

Merged
merged 3 commits into from
Feb 3, 2021

Conversation

jamiesnape
Copy link
Contributor

@jamiesnape jamiesnape commented Feb 1, 2021

Toward #13648.


This change is Reviewable

@jamiesnape
Copy link
Contributor Author

@drake-jenkins-bot mac-catalina-clang-bazel-experimental-release please

@jamiesnape
Copy link
Contributor Author

+@soonho-tri for feature review.

Copy link
Member

@soonho-tri soonho-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

BTW, could you check if we can remove these lines with this update https://github.com/RobotLocomotion/drake/blob/master/tools/macos.bazelrc#L5-L8 ?

Reviewed 4 of 4 files at r1.
Reviewable status: needs at least two assigned reviewers, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)

Copy link
Contributor Author

@jamiesnape jamiesnape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. I imagine we can as I don't think I have remembered to install that bazelrc file locally for a while.

Reviewable status: needs at least two assigned reviewers, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)

@jamiesnape
Copy link
Contributor Author

@drake-jenkins-bot mac-catalina-clang-bazel-experimental-release please

Copy link
Member

@soonho-tri soonho-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: needs at least two assigned reviewers, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)

@jamiesnape
Copy link
Contributor Author

Looks like we are good with removing the flag. I guess you are platform reviewer today. Do you think we need one?

@jamiesnape jamiesnape added the status: commits are properly curated https://drake.mit.edu/reviewable.html#curated-commits label Feb 3, 2021
@soonho-tri soonho-tri added the status: single reviewer ok https://drake.mit.edu/reviewable.html label Feb 3, 2021
@soonho-tri
Copy link
Member

I just added the single reviewer ok label.

@jamiesnape jamiesnape merged commit d53de64 into RobotLocomotion:master Feb 3, 2021
@jamiesnape jamiesnape deleted the unbreak-big-sur branch February 3, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters configuration: mac priority: medium status: commits are properly curated https://drake.mit.edu/reviewable.html#curated-commits status: single reviewer ok https://drake.mit.edu/reviewable.html unused team: kitware
Development

Successfully merging this pull request may close these issues.

2 participants