-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for new macOS versioning scheme and sync minimum compiler and CMake versions for macOS #14608
Conversation
@drake-jenkins-bot mac-catalina-clang-bazel-experimental-release please |
+@soonho-tri for feature review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, could you check if we can remove these lines with this update https://github.com/RobotLocomotion/drake/blob/master/tools/macos.bazelrc#L5-L8 ?
Reviewed 4 of 4 files at r1.
Reviewable status: needs at least two assigned reviewers, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do. I imagine we can as I don't think I have remembered to install that bazelrc
file locally for a while.
Reviewable status: needs at least two assigned reviewers, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
@drake-jenkins-bot mac-catalina-clang-bazel-experimental-release please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: needs at least two assigned reviewers, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
Looks like we are good with removing the flag. I guess you are platform reviewer today. Do you think we need one? |
I just added the |
Toward #13648.
This change is