Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add renamed copies of RobotLocomotion/lcmtypes used by Drake #14885

Merged

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Apr 11, 2021

These are copied from https://github.com/RobotLocomotion/lcmtypes/tree/821ff4b, with edits to change the package and message names to match Drake conventions.

This is in preparation for #14884 towards #14362.


This change is Reviewable

These are copied from https://github.com/RobotLocomotion/lcmtypes as
of 821ff4b463a9cb8f616914d87289714fcb356a92, with edits to change the
package and message names to match Drake conventions.

Co-authored-by: Kunimatsu Hashimoto <kunimatsu.hashimoto@tri.global>
@jwnimmer-tri jwnimmer-tri added priority: high status: single reviewer ok https://drake.mit.edu/reviewable.html labels Apr 11, 2021
@jwnimmer-tri jwnimmer-tri marked this pull request as ready for review April 11, 2021 02:27
Copy link
Contributor

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1.
Reviewable status: needs platform reviewer assigned, needs at least one assigned reviewer (waiting on @jwnimmer-tri)

@ggould-tri ggould-tri self-assigned this Apr 12, 2021
Copy link
Contributor

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@ggould-tri

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee ggould-tri(platform) (waiting on @jwnimmer-tri)

@jwnimmer-tri jwnimmer-tri merged commit 0c52ff4 into RobotLocomotion:master Apr 12, 2021
@jwnimmer-tri jwnimmer-tri deleted the lcmtypes-robotlocomotion-add branch April 12, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants