Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move semantic-version to source distribution requirements #14907

Merged
merged 1 commit into from Apr 15, 2021
Merged

Move semantic-version to source distribution requirements #14907

merged 1 commit into from Apr 15, 2021

Conversation

jamiesnape
Copy link
Contributor

@jamiesnape jamiesnape commented Apr 15, 2021

Fixes a misclassification in #14784.


This change is Reviewable

@jamiesnape jamiesnape added unused team: kitware component: build system Bazel, CMake, dependencies, memory checkers, linters labels Apr 15, 2021
@jamiesnape
Copy link
Contributor Author

@drake-jenkins-bot mac-big-sur-unprovisioned-clang-bazel-experimental-release please

@jamiesnape
Copy link
Contributor Author

+@jwnimmer-tri for feature review.

@jwnimmer-tri jwnimmer-tri added the status: single reviewer ok https://drake.mit.edu/reviewable.html label Apr 15, 2021
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: both +(status: single reviewer ok).

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform) (waiting on @jamiesnape)

@jwnimmer-tri jwnimmer-tri merged commit 625669c into RobotLocomotion:master Apr 15, 2021
@jamiesnape jamiesnape deleted the semantic-version-requirements branch April 16, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters status: single reviewer ok https://drake.mit.edu/reviewable.html unused team: kitware
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants