-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bind copyability of schema types #16261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+(release notes: yes)
+@jwnimmer-tri is this the correct idiom?
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers (waiting on @jwnimmer-tri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup!
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers (waiting on @ggould-tri)
bindings/pydrake/common/test/schema_test.py, line 15 at r1 (raw file):
self.assertIsInstance(dut, mut.Distribution) copy.copy(dut) copy.deepcopy(dut)
This code is slightly at odds with this helper method's docstring.
The abstract base class's "base methods" do not offer any help for copy-ability. However, we expect that all concrete subclasses must be copyable. Changing the docstring to clarify this should suffice.
Ditto for similar docstrings, throughout.
78656e9
to
7557caf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers (waiting on @jwnimmer-tri)
bindings/pydrake/common/test/schema_test.py, line 15 at r1 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
This code is slightly at odds with this helper method's docstring.
The abstract base class's "base methods" do not offer any help for copy-ability. However, we expect that all concrete subclasses must be copyable. Changing the docstring to clarify this should suffice.
Ditto for similar docstrings, throughout.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: needs at least two assigned reviewers (waiting on @ggould-tri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+(status: single reviewer ok)
Reviewable status:
complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform) (waiting on @ggould-tri)
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)