Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind copyability of schema types #16261

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

ggould-tri
Copy link
Contributor

@ggould-tri ggould-tri commented Dec 20, 2021

This change is Reviewable

@ggould-tri ggould-tri added the release notes: fix This pull request contains fixes (no new features) label Dec 20, 2021
Copy link
Contributor Author

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+(release notes: yes)
+@jwnimmer-tri is this the correct idiom?

Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers (waiting on @jwnimmer-tri)

Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

:lgtm: both.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers (waiting on @ggould-tri)


bindings/pydrake/common/test/schema_test.py, line 15 at r1 (raw file):

        self.assertIsInstance(dut, mut.Distribution)
        copy.copy(dut)
        copy.deepcopy(dut)

This code is slightly at odds with this helper method's docstring.

The abstract base class's "base methods" do not offer any help for copy-ability. However, we expect that all concrete subclasses must be copyable. Changing the docstring to clarify this should suffice.

Ditto for similar docstrings, throughout.

Copy link
Contributor Author

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers (waiting on @jwnimmer-tri)


bindings/pydrake/common/test/schema_test.py, line 15 at r1 (raw file):

Previously, jwnimmer-tri (Jeremy Nimmer) wrote…

This code is slightly at odds with this helper method's docstring.

The abstract base class's "base methods" do not offer any help for copy-ability. However, we expect that all concrete subclasses must be copyable. Changing the docstring to clarify this should suffice.

Ditto for similar docstrings, throughout.

Done.

Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: needs at least two assigned reviewers (waiting on @ggould-tri)

@ggould-tri ggould-tri added the status: single reviewer ok https://drake.mit.edu/reviewable.html label Dec 20, 2021
Copy link
Contributor Author

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+(status: single reviewer ok)

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform) (waiting on @ggould-tri)

@ggould-tri ggould-tri merged commit e62f964 into RobotLocomotion:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants