Remove deprecated code 2022-05 #17076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: low
status: single reviewer ok
|
+@xuchenhan-tri for both reviews per schedule, please. |
There was a problem hiding this comment.
Reviewed 32 of 32 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee xuchenhan-tri(platform) (waiting on @jwnimmer-tri)
a discussion (no related file):
There's
/// (To be marked deprecated as of 2022-05-01)
/// Compatibility alias; do not use.
using Options = LoadYamlOptions;
in yaml_read_archive.h in case that's not already on your radar.
jwnimmer-tri
commented
May 2, 2022
There was a problem hiding this comment.
Reviewable status:
a discussion (no related file):
Previously, xuchenhan-tri wrote…
There's
/// (To be marked deprecated as of 2022-05-01) /// Compatibility alias; do not use. using Options = LoadYamlOptions;in
yaml_read_archive.hin case that's not already on your radar.
Yup, thanks! I was going to save that for a different PR.
aykut-tri
pushed a commit
to aykut-tri/drake
that referenced
this pull request
May 27, 2022
aykut-tri
pushed a commit
to aykut-tri/drake
that referenced
this pull request
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is