Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Upgrade petsc to latest release v3.17.1 #17273

Merged
merged 2 commits into from May 26, 2022

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented May 26, 2022

This is a rework of #17119. Closes #17093.


This change is Reviewable

Co-authored-by: Betsy McPhail <betsy.mcphail@kitware.com>
@jwnimmer-tri jwnimmer-tri added priority: low release notes: fix This pull request contains fixes (no new features) labels May 26, 2022
@jwnimmer-tri
Copy link
Collaborator Author

+@xuchenhan-tri is looks like this PETSc upgrade perhaps added some more modules that we'll need to exclude? Could you take a look at this PR and see if you can figure out the fix? You can push changes to the PR if you like.

Copy link
Contributor

@xuchenhan-tri xuchenhan-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for CI to confirm no linker error. Otherwise :lgtm:
(Thanks for helping with maintaining @jwnimmer-tri @BetsyMcPhail).

Reviewed 12 of 13 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)

@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot mac-big-sur-clang-bazel-experimental-release please

@jwnimmer-tri jwnimmer-tri marked this pull request as ready for review May 26, 2022 16:00
@jwnimmer-tri
Copy link
Collaborator Author

+@sammy-tri for platform review per schedule, please.

Copy link
Contributor

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 13 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)

@jwnimmer-tri jwnimmer-tri merged commit e0bce06 into RobotLocomotion:master May 26, 2022
@jwnimmer-tri jwnimmer-tri deleted the petsc-upgrade branch May 26, 2022 18:02
@jwnimmer-tri jwnimmer-tri added status: squashing now https://drake.mit.edu/reviewable.html#curated-commits and removed status: do not merge labels May 26, 2022
aykut-tri pushed a commit to aykut-tri/drake that referenced this pull request May 27, 2022
…17273)

Co-authored-by: Betsy McPhail <betsy.mcphail@kitware.com>
Co-authored-by: Xuchen Han <xuchen.han@tri.global>
aykut-tri pushed a commit to aykut-tri/drake that referenced this pull request Jun 1, 2022
…17273)

Co-authored-by: Betsy McPhail <betsy.mcphail@kitware.com>
Co-authored-by: Xuchen Han <xuchen.han@tri.global>
hongkai-dai pushed a commit to hongkai-dai/drake that referenced this pull request Jun 6, 2022
…17273)

Co-authored-by: Betsy McPhail <betsy.mcphail@kitware.com>
Co-authored-by: Xuchen Han <xuchen.han@tri.global>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: fix This pull request contains fixes (no new features) status: squashing now https://drake.mit.edu/reviewable.html#curated-commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade externals to latest - May 2022
3 participants