Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[visualization] Repair meldis --host option #17548

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

rpoyner-tri
Copy link
Contributor

@rpoyner-tri rpoyner-tri commented Jul 11, 2022

Broken by #16981.


This change is Reviewable

@rpoyner-tri rpoyner-tri added release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html labels Jul 11, 2022
Copy link
Contributor Author

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+(status: single reviewer ok) @jwnimmer-tri for both reviews.

FYI @pathammer

I suspect this was essentially merge breakage caused by trusting tools to merge a long-lived branch without frequent references to master (either by merging or rebasing).

Reviewable status: needs platform reviewer assigned, needs at least one assigned reviewer

@jwnimmer-tri jwnimmer-tri self-assigned this Jul 11, 2022
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: both.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform) (waiting on @rpoyner-tri)

Copy link
Contributor Author

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The theory of "release notes: none" is that this will merge before the Drake release this week. If it doesn't make it, then I'll file an issue so it can get fixed with notes in the next round. FYI @ggould-tri

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform) (waiting on @rpoyner-tri)

@jwnimmer-tri jwnimmer-tri merged commit 3edbde4 into RobotLocomotion:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants