[workspace] Upgrade vtk_internal to latest commit #21387
Conversation
jwnimmer-tri
added
priority: low
status: single reviewer ok
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @BetsyMcPhail)
a discussion (no related file):
VTK is broken upstream:
Common/Core/vtkObjectFactory.h:304:12: error: invalid 'static_cast' from type 'drake_vendor::vtkObject*' to type 'drake_vendor::vtkGLTFTexture*'
304 | return static_cast<thisClass*>(ret); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
IO/Geometry/vtkGLTFTexture.cxx:13:1: note: in expansion of macro 'vtkStandardNewMacro'
The vtkGLTFTexture class inherits vtkObjectBase instead of vtkObject for some reason, which means that the standard new macro cannot be used.
Hopefully someone at Kitware can fix it and then we can bump to the newer git commit here.
BetsyMcPhail
added this to In progress
in build system, continuous integration, distribution
There was a problem hiding this comment.
+@rpoyner-tri for both reviews, please.
Reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: LGTM missing from assignees jwnimmer-tri(platform),rpoyner-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @BetsyMcPhail)
a discussion (no related file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
VTK is broken upstream:
Common/Core/vtkObjectFactory.h:304:12: error: invalid 'static_cast' from type 'drake_vendor::vtkObject*' to type 'drake_vendor::vtkGLTFTexture*' 304 | return static_cast<thisClass*>(ret); \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ IO/Geometry/vtkGLTFTexture.cxx:13:1: note: in expansion of macro 'vtkStandardNewMacro'The vtkGLTFTexture class inherits
vtkObjectBaseinstead ofvtkObjectfor some reason, which means that the standard new macro cannot be used.Hopefully someone at Kitware can fix it and then we can bump to the newer git commit here.
The https://gitlab.kitware.com/vtk/vtk/-/merge_requests/11117 seems sensible, so I cherry-picked it here. We can drop it at the next upgrade.
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @BetsyMcPhail)
jwnimmer-tri
added
the
status: squashing now
BetsyMcPhail
moved this from In progress
to Done
in build system, continuous integration, distribution
jwnimmer-tri
moved this from Done
to Done (previously)
in build system, continuous integration, distribution
jwnimmer-tri
moved this from Done (previously)
to Done
in build system, continuous integration, distribution
jwnimmer-tri
moved this from Done
to Done (previously)
in build system, continuous integration, distribution
Towards #21372
This change is