Add check to see if have cross-scene data #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteflorence
force-pushed
the
pf-add-cross-scene-check
branch
from
154f164
to
c99a16a
Compare
manuelli
reviewed
Nov 8, 2018
| or not os.path.isdir(dataset.get_full_path_for_scene(scene_name_b)): | ||
| print("at least one of these scene names does not exist:", scene_name_a, scene_name_b) | ||
| continue | ||
| print("these scene names both exist:", scene_name_a, scene_name_b) |
There was a problem hiding this comment.
I would remove this print statement, it's unecessary.
| or not os.path.isdir(dataset.get_full_path_for_scene(scene_name_b)): | ||
| print("at least one of these scene names does not exist:", scene_name_a, scene_name_b) | ||
| continue | ||
| print("these scene names exist:", scene_name_a, scene_name_b) |
There was a problem hiding this comment.
I would remove this print statement, it's unecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributed from @dan9thsense
We should test before merging, but looks good.