Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3 str in incoming #541

Merged

Conversation

mvollrath
Copy link
Contributor

Fixes Python 2 unicode issues.

Fixes Python 2 unicode issues.
@mvollrath
Copy link
Contributor Author

Supersedes #539 to fix regression in #514

@mvollrath mvollrath merged commit f3888b6 into RobotWebTools:develop Nov 24, 2020
@moriarty
Copy link

moriarty commented Dec 8, 2020

This adds a dependency on python-future which did not exist before and breaks at runtime when it is not installed

moriarty added a commit to moriarty/rosbridge_suite that referenced this pull request Dec 8, 2020
This was not fixed with fadffa0
The dependency was added with RobotWebTools#541

Python doesn't have build dependencies, only exec dependencies
mvollrath pushed a commit that referenced this pull request Dec 8, 2020
* fix python-future dependency

This was not fixed with fadffa0
The dependency was added with #541

Python doesn't have build dependencies, only exec dependencies

* update ros-tooling/action-ros-ci

See:
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

This was fixed upstream
- ros-tooling/action-ros-ci#429
- ros-tooling/action-ros-ci#430

* update ros-tooling/setup-ros

See:

https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

This is needed for upstream fix
- ros-tooling/setup-ros#303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants