Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update everything to 0.1.0 for release #430

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Update everything to 0.1.0 for release #430

merged 2 commits into from
Nov 18, 2020

Conversation

emersonknapp
Copy link
Contributor

Fixes #429 - addPath deprecation error by updating dependencies.

Moves to minor version 1 in order to allow for better communicating API change vs patch fixes in the future (without committing to 1.0)

Fixes addPath deprecation error by updating dependencies.
Moves to minor version 1 in order to allow for better messaging about API change vs patch fixes in the future.

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp emersonknapp requested a review from a team as a code owner November 18, 2020 01:40
@emersonknapp emersonknapp requested review from jaisontj and dabonnie and removed request for a team November 18, 2020 01:40
@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #430 (2aace28) into master (c941048) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   37.85%   37.85%           
=======================================
  Files           1        1           
  Lines         140      140           
  Branches       29       29           
=======================================
  Hits           53       53           
  Misses         87       87           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c941048...2aace28. Read the comment docs.

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp emersonknapp requested review from thomas-moulard and prajakta-gokhale and removed request for dabonnie November 18, 2020 02:03
@emersonknapp emersonknapp merged commit a66f0e3 into master Nov 18, 2020
@emersonknapp emersonknapp deleted the release-0-1-0 branch November 18, 2020 03:43
mvollrath pushed a commit to RobotWebTools/rosbridge_suite that referenced this pull request Dec 8, 2020
* fix python-future dependency

This was not fixed with fadffa0
The dependency was added with #541

Python doesn't have build dependencies, only exec dependencies

* update ros-tooling/action-ros-ci

See:
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

This was fixed upstream
- ros-tooling/action-ros-ci#429
- ros-tooling/action-ros-ci#430

* update ros-tooling/setup-ros

See:

https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

This is needed for upstream fix
- ros-tooling/setup-ros#303
tfoote added a commit to ros2/rmw_cyclonedds that referenced this pull request Aug 31, 2022
Need ros-tooling/action-ros-ci#430

Signed-of-by: Tully Foote <tfoote@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All runs of action-ros-ci failing due to set-env command disabled
2 participants