Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MainHand > OneHand transmog #2

Closed
ghost opened this issue May 24, 2015 · 13 comments
Closed

MainHand > OneHand transmog #2

ghost opened this issue May 24, 2015 · 13 comments

Comments

@ghost
Copy link

ghost commented May 24, 2015

Hello. Is there any way to implement transmogrification MainHand to OneHand and OneHand to MainHand? I cannot enable Mixed Weapon Types but i need to allow to transmog for ex. Spell Power Daggers to Rogue Daggers and vice versa.

Thank you.

@Rochet2
Copy link
Owner

Rochet2 commented May 24, 2015

Try editing these lines out:

source->InventoryType == INVTYPE_WEAPONMAINHAND ||
source->InventoryType == INVTYPE_WEAPONOFFHAND))

They block one hand transmogrification with main and off hand weapons.

There has been so much requests about this that I might make a setting.
However you must understand that some items are like the warglaives of azzinoth. The item model is made so it only fits the main hand and will not properly fit the off hand.

@ghost
Copy link
Author

ghost commented Jun 5, 2015

Still trying! :D

Any idea, how to enable transmoging to items with for ex. Chance on hit? http://www.wowhead.com/item=7717/ravager

@Rochet2
Copy link
Owner

Rochet2 commented Jun 6, 2015

Set Transmogrification.IgnoreReqStats = 1 in config

@Rochet2 Rochet2 closed this as completed Jun 6, 2015
@Rochet2 Rochet2 reopened this Jun 6, 2015
@ghost
Copy link
Author

ghost commented Jun 6, 2015

Edited much code, worked, thank you :)

@Keader
Copy link

Keader commented Jul 4, 2015

diff --git a/src/server/scripts/Custom/Transmog/Transmogrification.cpp b/src/server/scripts/Custom/Transmog/Transmogrification.cpp
index e166534..9cd4d3a 100644
--- a/src/server/scripts/Custom/Transmog/Transmogrification.cpp
+++ b/src/server/scripts/Custom/Transmog/Transmogrification.cpp
@@ -388,9 +388,7 @@ bool Transmogrification::CanTransmogrifyItemWithItem(Player* player, ItemTemplat
     if (source->InventoryType != target->InventoryType)
     {
         if (source->Class == ITEM_CLASS_WEAPON &&
-            (IsRangedWeapon(target->Class, target->SubClass) != IsRangedWeapon(source->Class, source->SubClass) ||
-            source->InventoryType == INVTYPE_WEAPONMAINHAND ||
-            source->InventoryType == INVTYPE_WEAPONOFFHAND))
+            (IsRangedWeapon(target->Class, target->SubClass) != IsRangedWeapon(source->Class, source->SubClass)))
             return false;
         if (source->Class == ITEM_CLASS_ARMOR &&
             !((source->InventoryType == INVTYPE_CHEST && target->InventoryType == INVTYPE_ROBE) ||

Works for me , ty 👍

@Rochet2 You tell if doing so can bring any side effects?

@Rochet2
Copy link
Owner

Rochet2 commented Jul 4, 2015

You can transmogrify for example warglaives to the wrong hands

Rochet2 pushed a commit that referenced this issue Nov 5, 2016
Fixes Spell_dbc spells: -

Id,Comment
12694,Idol Room Spawn A
12949,Idol Room Spawn End Boss
14801,Idol Room Spawn C
14802,Idol Room Spawn B
16369,Bugs
16370,Maggots
16619,Quest - Temporal Parasite Death Summon
16630,Quest - Temporal Parasite Summon #2
16631,Quest - Temporal Parasite Summon #3
17408,Summon Freed Soul
19826,Summon Blackwing Legionnaire
19827,Summon Blackwing Mage
19828,Summon Death Talon Dragonspawn
20172,Summon Onyxian Whelp
20734,Black Arrow
21110,Summon Son of Flame B
21111,Summon Son of Flame C
21112,Summon Son of Flame D
21113,Summon Son of Flame E
21114,Summon Son of Flame F
21115,Summon Son of Flame G
21116,Summon Son of Flame H
21117,Summon Son of Flame A
21287,Conjure Lokholar the Usurper DND
22803,Dire Maul Trap - Summon
22821,Warpwood Spores
23118,Conjure Scourge Footsoldier DND
23119,Conjure Peasant DND
23121,Conjure Peasant DND
23209,Terrordale Haunting Spirit #2
23253,Terrordale Haunting Spirit #3
24081,Summon Spawn of Mar'li
24215,Create Heart of Hakkar Explosion
24250,Summon Zulian Stalker
24349,Summon Bloodlord's Raptor
25151,Summon Vekniss Drone
25708,Summon Hive'Zara Swarmer
26140,Summon Hook Tentacle
26144,Summon Eye Tentacle
26145,Summon Eye Tentacle
26146,Summon Eye Tentacle
26147,Summon Eye Tentacle
26148,Summon Eye Tentacle
26149,Summon Eye Tentacle
26150,Summon Eye Tentacle
26151,Summon Eye Tentacle
26191,Teleport Giant Hook Tentacle
26216,Summon Giant Hook Tentacles
26396,Summon Portal Ground State
26477,Summon Giant Portal Ground State
26538,Summon Hive'Zara Larva
26539,Summon Hive'Zara Larva
26577,Summon Toxic Slime
26617,Summon Ouro Mound
26768,Summon Giant Eye Tentacles
26837,Summon InCombat Trigger
27178,Defile
27643,Summon Spirit of Jarien
27644,Summon Spirit of Sothos
27690,Summon Bone Minion
27691,Summon Bone Minion
27692,Summon Bone Minion
27693,Summon Bone Minion
27884,Summon Trainee
27921,Summon Spectral Trainee
27932,Summon Spectral Knight
27939,Summon Spectral Rivendare
28008,Summon Knight
28010,Summon Mounted Knight
28175,(DND) Summon Crystal Minion, Ghost
28177,(DND) Summon Crystal Minion, Skeleton
28179,(DND) Summon Crystal Minion, Ghoul
28217,Summon Zombie Chow
28227,(DND) Summon Crystal Minion, finder
28289,(DND) Summon Crystal Minion, Ghoul Uncommon
28290,(DND) Summon Crystal Minion, Ghost Uncommon
28291,(DND) Summon Crystal Minion, Skeleton Uncommon
28421,Summon Type A
28422,Summon Type B
28423,Summon Type C
28454,Summon Type D
28561,Summon Blizzard
28627,Summon Web Wrap
29141,Marauding Crust Borer
29218,Summon Flame Ring
29329,Summon Sapphiron's Wing Buffet
29434,Summon Maexxna Spiderling
29508,Summon Crypt Guard
29857,Summon Astral Spark
30076,Summon Maexxna Spiderling
30083,Summon Root Thresher
30236,Summon Astral Flare NE
30239,Summon Astral Flare NW
30240,Summon Astral Flare SE
30241,Summon Astral Flare SW
30630,Debris
30737,Summon Heathen
30785,Summon Reaver
30786,Summon Sharpshooter
30792,Summon Ravager Ambusher
30825,Summon Siltfin Ambusher
30826,Summon Wildkin Ambusher
30827,Summon Bristlelimb Ambusher
30828,Summon Sunhawk Ambushers
30954,Free Webbed Creature
30955,Free Webbed Creature
30956,Free Webbed Creature
30957,Free Webbed Creature
30958,Free Webbed Creature
30959,Free Webbed Creature
30960,Free Webbed Creature
30961,Free Webbed Creature
30962,Free Webbed Creature
30963,Free Webbed Creature
30976,Summon Gauntlet Guards
31010,Free Webbed Creature
31318,Summon Infinite Assassin
31321,Summon Black Morass Rift Lord
31374,Summon Netherstorm Backlash
31391,Summon Black Morass Chrono Lord Deja
31392,Summon Black Morass Temporus
31393,Summon Black Morass Rift End Boss
31421,Summon Infinite Chronomancer
31528,Summon Gnome
31529,Summon Gnome
31530,Summon Gnome
31544,Summon Distiller
31545,Summon Distiller
31593,Summon Greater Manawraith
31995,Shattered Rumbler
32114,Summon Wisp
32151,Infernal
32283,Focus Fire
32360,Summon Stolen Soul
32579,Portal Beam
32632,Summon Overrun Target
33121,A Vision of the Forgotten
33229,Wrath of the Astromancer
33242,Infernal
33362,Summon Astromancer Adds
33363,Summon Infinite Executioner
33364,Summon Infinite Vanquisher
33367,Summon Astromancer Priest
33495,Summon Random Tractor
33514,Summon Random Tractor
33515,Summon Random Tractor
33516,Summon Random Tractor
33517,Summon Random Tractor
33518,Summon Random Tractor
33519,Summon Random Tractor
33520,Summon Random Tractor
33567,Summon Void Portal D
33636,Infernal
33677,Incite Chaos
33680,Incite Chaos
33681,Incite Chaos
33682,Incite Chaos
33683,Incite Chaos
33901,Summon Crystalhide Crumbler
33927,Summon Void Summoner
34064,Soul Split
34125,Spotlight
34175,Arcane Orb Primer
34810,Summon Mender 1
34817,Summon Reservist 1
34818,Summon Reservist 2
34819,Summon Reservist 3
35127,Summon Boom Bot Target
35128,Summon Boom Bot
35130,Summon Boom Bot
35136,Summon Captured Critter
35142,Drijya Summon Imp
35145,Drijya Summon Doomguard
35146,Drijya Summon Terrorguard
35153,Summon Nether Charge NE
35256,Summon Unstable Mushroom
35430,Infernal
35687,Summon Seeping Sludge Globule
35688,Summon Void Waste Globule
35737,Summon Deadsoul Orb
35861,Summon Nether Vapor
35862,Summon Nether Vapor
35863,Summon Nether Vapor
35864,Summon Nether Vapor
35904,Summon Nether Charge NW
35905,Summon Nether Charge SE
35906,Summon Nether Charge SW
35937,Summon Ambush
36026,Conjure Elemental Soul: Earth
36036,Summon Netherstorm Target
36042,Summon Farahlon Crumbler
36043,Summon Farahlon Crumbler
36044,Summon Farahlon Crumbler
36045,Summon Farahlon Shardling
36046,Summon Farahlon Shardling
36047,Summon Farahlon Shardling
36048,Summon Motherlode Shardling
36049,Summon Motherlode Shardling
36050,Summon Motherlode Shardling
36112,Conjure Elemental Soul: Fire
36168,Conjure Elemental Soul: Water
36180,Conjure Elemental Soul: Air
36221,Summon  Eye of the Citadel
36229,Summon Infinite Assassin
36231,Summon Infinite Chronomancer
36232,Summon Infinite Executioner
36233,Summon Infinite Vanquisher
36234,Summon Black Morass Rift Lord Alt
36235,Summon Black Morass Rift Keeper
36236,Summon Black Morass Rift Keeper
36379,Call Skitterers
36521,Summon Arcane Explosion
36579,Summon Netherock Crumbler
36584,Summon Netherock Crumbler
36585,Summon Netherock Crumbler
36595,Summon Apex Crumbler
36596,Summon Apex Crumbler
36597,Summon Apex Crumbler
36724,Summon Phoenix Egg
36818,Attacking Infernal
36865,Summon Gnome Cannon Channel Target (DND)
37177,Summon Black Morass Infinite Chrono-Lord
37178,Summon Black Morass Infinite Timereaver
37394,Summon Destroyed Sentinel
37457,Windsor Dismisses Horse DND
37545,Summon Phantom
37606,Summon Infinite Assassin
37735,Summon Inner Demon
37758,Bone Wastes - Summon Auchenai Spirit
37766,Summon Murloc A1
37772,Summon Murloc B1
37773,Summon Elemental A1
37774,Summon Elemental B1
37911,Summon Elemental A2
37912,Summon Elemental A3
37914,Summon Elemental B2
37916,Summon Elemental B3
37923,Summon Murloc A2
37925,Summon Murloc A3
37926,Summon Murloc A4
37927,Summon Murloc A5
37928,Summon Murloc B2
37929,Summon Murloc B3
37931,Summon Murloc B4
37932,Summon Murloc B5
37947,Summon Crazed Shardling
37948,Summon Crazed Shardling
37949,Summon Crazed Shardling
38019,Summon Wave A Mob
38111,Summon Horde Bat Rider Guard
38114,Summon Horde Rooftop Alarm Sensor
38118,Summon Area 52 Death Machine Guard
38124,Summon Horde Ground Alarm Sensor
38137,Summon Sky Marker
38179,Summon Alliance Ground Alarm Sensor
38180,Summon Alliance Rooftop Alarm Sensor
38181,Summon Alliance Gryphon Guard
38188,Summon Corrupted Spawn
38189,Summon Corrupted Spawn
38190,Summon Corrupted Spawn
38191,Summon Corrupted Spawn
38198,Summon Purified Spawn
38199,Summon Purified Spawn
38200,Summon Purified Spawn
38201,Summon Purified Spawn
38242,Summon Wave C Mob
38244,Summon Wave D Mob
38247,Summon Wave B Mob
38261,Summon Area 52 Rooftop Alarm Sensor
38266,Summon Stormspire Ethereal Guard
38268,Summon Scryer Dragonhawk Guard
38270,Summon Stormspire Rooftop Alarm Sensor
38271,Summon Scryer Rooftop Alarm Sensor
38278,Summon Aldor Gryphon Guard
38283,Summon Aldor Rooftop Alarm Sensor
38286,Summon Sporeggar Sporebat Guard
38287,Summon Sporeggar Rooftop Alarm Sensor
38288,Summon Toshley Guard
38291,Summon Toshley Rooftop Alarm Sensor
38402,Summon Cenarion Storm Crow Guard
38403,Summon Cenarion Expedition Rooftop Alarm Sensor
38489,Summon Wave E Mob
38490,Summon Wave E Mob
38492,Summon Wave E Mob
38493,Summon Wave E Mob
38512,Fiery Boulder
38587,Summon Spirit of Redemption
38651,Summon Rancid Mushroom
38854,Hatch Arakkoa
38865,Hatch Bad Arakkoa
38874,Summon Mushoom Creature
38888,Summon Morcrush Shardling
38889,Summon Morcrush Shardling
38890,Summon Morcrush Shardling
39080,Summon Mountain Shardling
39081,Summon Vortex Shardling
39110,Summon Phoenix Adds
39111,Summon Furious Nether-wraith
39186,Summon Random Tractor
39191,Sha'tari Flames
39302,Quest - The Exorcism, Summon Foul Purge
39305,Summon Flying Skull
Rochet2 pushed a commit that referenced this issue Dec 26, 2017
@ghost
Copy link
Author

ghost commented Mar 12, 2018

confirm!

all cods changed to new version and icant use get cod patched.
not found > a/src/server/scripts/Custom/Transmog/Transmogrification.cpp
is it > --- a/src/server/scripts/Custom/Transmog/Transmogrifier.cpp

how to fixed main hand and off hand for transmog all weapons!
i need to allow to transmog for daggers - onehands and towhands!

What should be changed!

@Rochet2
Copy link
Owner

Rochet2 commented Mar 12, 2018

@IRGC The file is now at /src/server/game/Entities/Item/Transmogrification.cpp

@ghost
Copy link
Author

ghost commented Mar 12, 2018

@rochet

not found lines on /src/server/game/Entities/Item/Transmogrification.cpp

  •        source->InventoryType == INVTYPE_WEAPONMAINHAND ||
    
  •        source->InventoryType == INVTYPE_WEAPONOFFHAND))
    

can u give me update patch for fixed?

@Rochet2
Copy link
Owner

Rochet2 commented Mar 12, 2018

@IRGC must change
(source->InventoryType == INVTYPE_WEAPON || source->InventoryType == INVTYPE_2HWEAPON)))))
to
(source->InventoryType == INVTYPE_2HWEAPON)))))

@ghost
Copy link
Author

ghost commented Mar 12, 2018

i changed
but not work for me

icant transmog main hand and off hands ! to onehands - daggers - tow hands!

:(

@Rochet2
Copy link
Owner

Rochet2 commented Mar 12, 2018

Config for it implemented:
da23246
Enables 2h to 1h and any mixing of 1h

@Rochet2 Rochet2 closed this as completed Mar 12, 2018
@ghost
Copy link
Author

ghost commented Mar 13, 2018

did you know you're so good?:)

Thanks a lot .

Rochet2 pushed a commit that referenced this issue Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants