Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable GIF preview and add Action Buttons #16

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

AmanNegi
Copy link
Collaborator

Description 📝

  • Implement UIKit components and Buttons to provide user with an option to preview the GIF before sending to the channel.
  • The user can decide to re-generate the GIF or send the generated GIF to the channel.

Fixes: #15

Demo 📹

actions-demo.mp4

@AmanNegi
Copy link
Collaborator Author

@Nabhag8848 Could you please review this and let me know if any changes are required.

@AmanNegi AmanNegi requested a review from Nabhag8848 July 15, 2024 03:44
@Nabhag8848
Copy link
Collaborator

@AmanNegi merge conflicts

- implement UIKit components and Buttons to provide user with an option
  to preview the GIF before sending to the channel.
- the user can decide to re-generate the GIF or send the generated GIF
  to the channel.
@AmanNegi AmanNegi force-pushed the feat/preview-before-sending branch from 3cc8b0e to 1d181d8 Compare July 21, 2024 14:05
@AmanNegi
Copy link
Collaborator Author

@AmanNegi merge conflicts

Fixed the merge conflicts. ✔️

Copy link
Collaborator

@Nabhag8848 Nabhag8848 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/handlers/ExecuteBlockActionHandler.ts Outdated Show resolved Hide resolved
src/lib/RedefinePrompt.ts Outdated Show resolved Hide resolved
src/handlers/PreviewerHandler.ts Show resolved Hide resolved
@AmanNegi
Copy link
Collaborator Author

@Nabhag8848 I have made the requested changes. Could you please take a look!

Copy link
Collaborator

@Nabhag8848 Nabhag8848 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmanNegi LGTM !

@Nabhag8848 Nabhag8848 merged commit b9e0424 into RocketChat:main Jul 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Enable user to view GIF preview and provide options to regenerate/approve the generation
2 participants