Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW: Development documentation #15

Merged
merged 4 commits into from
Jul 31, 2022
Merged

Conversation

sidmohanty11
Copy link
Collaborator

Development documentation

@@ -1,2 +1,10 @@
# EmbeddedChat
An easy to use full-stack component (ReactJS + backend behaviors) embedding Rocket.Chat into your webapp

## Development
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe what this is. Show a screen capture of how it looks like.

How will the potential contributor be able to test his code?

How can this component be embedded into a web page or react app as it exists right now?

@Sing-Li
Copy link
Member

Sing-Li commented Jul 7, 2022

Please submit the README.md update ALONE as a separate PR (without any code). I'll be able to test and review the instructions. Hopefully helping out Rohan a bit on this.

@sidmohanty11
Copy link
Collaborator Author

@Sing-Li sure, I will update the whole README in this PR and when I'm done I'll tag you!

@sidmohanty11
Copy link
Collaborator Author

@Sing-Li as of now, can you please give a quick review of the documentation. I've added all the necessary steps that should be taken to set the component up.

The component hasn't been deployed yet, we can release it after the Auth and API get complete. After that npm install .... will work!

@Sing-Li
Copy link
Member

Sing-Li commented Jul 14, 2022

@sidmohanty11 when will the "auth and api" get completed? We need this to have good developer experience before the mid-term (in the next week or two).

How can new devs:

  1. embed this component in their web app
  2. start helping you to enhance this component

WITHOUT waiting for that work to complete?


*EmbeddedChat is a full-stack React component node module of the RocketChat application that is fully configurable, extensible, and flexible for use. It is tightly bound with the RocketChat server using Rocket.Chat nodejs SDK and its UI using RocketChat's Fuselage Design System.*

![embeddedchatwall](https://user-images.githubusercontent.com/73601258/178119162-ecabb9b7-e3ae-4c70-8ab2-f6c02856f4c6.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a good screen capture for this purpose.

It looks no different than a non-embedded chat window. Bringing up the bigger question of -- what is this project for?

Your screen capture should clearly show (ALL) the added values that this component bring to our community. This picture is your THOUSAND WORDS.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. 100% agreed. Let me search a bit around for mockups that I can use. I will send some samples in the channel.

@Sing-Li Sing-Li merged commit a2556af into RocketChat:main Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants