Fix/new icon components #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve auth added apis for slash, ui-iteractions, action-trigger Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
* Box replacement (RocketChat#224) * added ActionButton, Icon, Input Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com> improve auth Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com> added apis for slash, ui-iteractions, action-trigger Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com> slash-commands+ui-kit+theming Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com> slash-commands+ui-kit+theming --------- Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
* Box replacement (RocketChat#224) * added ActionButton, Icon, Input Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com> improve auth Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com> added apis for slash, ui-iteractions, action-trigger Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com> slash-commands+ui-kit+theming Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com> slash-commands+ui-kit+theming * html-embedd Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com> --------- Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
* Box replacement (RocketChat#224) * added ActionButton, Icon, Input Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com> improve auth Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com> added apis for slash, ui-iteractions, action-trigger Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com> slash-commands+ui-kit+theming Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com> slash-commands+ui-kit+theming * html-embedd Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com> * new/message-component+avatar Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com> --------- Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier we used font icons that needed to be included explicitly for the component and HTML embed to work. I have replaced them with SVG components. I have created a tool that will generate SVG icon components for only those icons that are required for this project. Hence we will now eliminate the import of assets for all icons (including unused icons) and explicitly import font files.