feat: configure EC remotely #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spiral-Memory
force-pushed
the
feat/configure-ec-remotely
branch
5 times, most recently
from
734fe9f
to
9683dd0
Compare
Spiral-Memory
force-pushed
the
feat/configure-ec-remotely
branch
2 times, most recently
from
4b94262
to
5fc56ef
Compare
|
Hey @sidmohanty11 , This PR is ready for review. It fixes some minor issues and mainly adds a feature to remotely configure the props. I've explained its workings in the PR description. Please take a look. Thanks! |
Spiral-Memory
force-pushed
the
feat/configure-ec-remotely
branch
from
bd4fd13
to
bf5fc7e
Compare
Spiral-Memory
force-pushed
the
feat/configure-ec-remotely
branch
from
552a64f
to
cd8789c
Compare
Spiral-Memory
force-pushed
the
feat/configure-ec-remotely
branch
from
b136e13
to
15e0426
Compare
sidmohanty11
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
This PR adds a feature to remotely configure EmbeddedChat using the EmbeddedChat RC app.
Acceptance Criteria Fulfillment
useRemotePropshook that overrides the existing props if any of the props match those in the remote configurationThe implementation is simple: before displaying the EmbeddedChat, we fetch the remote props from EC settings. If a new prop is present or an existing one needs to be overridden, it overrides the prop and then shows the EmbeddedChat component. These overrides happen only when
remoteOptis passed as true.We can't directly mutate the props, so I have added a state config that now handles the props accordingly.
Fixes #597
Video/Screenshots
2024-06-28.23-28-26.mp4