[IMPROVE] refactor hard-coded component data into parameters (react component props)

[nishant23122000]

Proposed changes

Put all Hardcoded content outside of component in app/data folder and improved the responsiveness of Infotiles and carousel component by adding media query.

ScreenShot

Before

After

[Sing-Li]

@nishant23122000 this is REALLY GOOD attempt! Glad you can "see" where we're going with this!! 👏

Please take up the challenge of:

Instead of factoring the massive parameter data seed structures as external-to-components data file (which is a paradox because they can and only be used by THAT INSTANCE of THAT COMPONENT) into global code space and polluting it .........

... add enough code into the components to make ALL OF THE DATA incoming props

This means that the data will ONLY be used to parameterize INSTANCES of the component(s) via props

<Component   data1="...some part of the data..."  data2="_more part of the data...">

within something like the index.js page or one of the demo pages pages/[_ids].js .

Hope you get what I'm talking about.

[nishant23122000]

Hi @Sing-Li , I think you are trying to explain that we should fetch hard-coded data from strapi and then pass it to any component as a prop as we did in the index.js file.

Let's say we have infotiles, we will create a collection for tiles in strapi and then fetch data from there. Right?

Will fetch array and then use the map in component as i did.

[Sing-Li]

@nishant23122000 For infotiles - partially yes. But let say for Github or Leaderboard components - we want parameterization at the "backend level" So the argument would be a URL for a Github repository, or URL to an instance of a contributors leaderboard.

For one single infotile - I think the parameterization should be right on the props of the component - say with Title , Description, TileImage

How we should initialize a collection of infotiles with data from strapi -- needs to be thought out some more. The mechanism should NOT hinder the use of one single infotile on a page (in which case it doesn't make sense to have the data always in strapi)

[lgtm-com]

This pull request introduces 1 alert and fixes 1 when merging ca58c55 into 3927e64 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

fixed alerts:

• 1 for Unused variable, import, function or class

[lgtm-com]

This pull request fixes 1 alert when merging d0bae71 into 3927e64 - view on LGTM.com

fixed alerts:

• 1 for Unused variable, import, function or class

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
11 out of 12 committers have signed the CLA.

✅ sidmohanty11
✅ Sing-Li
✅ debdutdeb
✅ samad-yar-khan
✅ nishant23122000
✅ demonicirfan
✅ abhinavkrin
✅ dudanogueira
✅ RonLek
✅ Dnouv
✅ nik23122000
❌ Rohan Lekhwani

---

Rohan Lekhwani seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[lgtm-com]

This pull request introduces 1 alert and fixes 1 when merging 21704ff into 6dbe41c - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

fixed alerts:

• 1 for Unused variable, import, function or class