Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Event Feature Added In Admin Dashboard #69

Merged
merged 7 commits into from
Jan 3, 2023
Merged

Edit Event Feature Added In Admin Dashboard #69

merged 7 commits into from
Jan 3, 2023

Conversation

ayush3160
Copy link
Contributor

Regarding to issue #59 , I have added a edit event component similar to event create component to edit the basic details of the event.

@ayush3160
Copy link
Contributor Author

@Dnouv , Can you please review this PR.

Dnouv
Dnouv requested changes Dec 26, 2022
View reviewed changes
app/components/conferences/admin/editEvent.js Outdated Show resolved Hide resolved
app/components/conferences/admin/editEvent.js Outdated Show resolved Hide resolved
@Dnouv
Copy link
Member

Dnouv commented Dec 26, 2022

Thanks for the PR @ayush3160. Please have a look at the comments.

@ayush3160
Copy link
Contributor Author

@Dnouv , I have separated the code for the form in a different component eventForm, So that it can be used in both the edit and create component. Also I have Added the functionality to edit the ticket details accordingly. Please have a look and let me know if any changes are required.

Thank You!

@Dnouv
Copy link
Member

Dnouv commented Dec 29, 2022 •
edited
Loading

Thank you for the changes @ayush3160

  1. The Event Image links are empty; please also fill in the details from the saved event.

Screenshot_20221229_112436

  1. The Tabs' order should be as follows:
  • Event Details
  • Speakers
  • Any other details

Also re-style the Event name and the Tabs to make it look more better.
Current order:

image

Please correct the above. Thank you!

@ayush3160
Copy link
Contributor Author

@Dnouv , Please have a look.

@Dnouv
Copy link
Member

Dnouv commented Dec 31, 2022

Thanks for the quick changes @ayush3160 ! LGTM.

Please also do this:

Also re-style the Event name and the Tabs to make it look more better.

See the last image comment: #69 (comment)

@Dnouv
Copy link
Member

Dnouv commented Jan 3, 2023

LGTM! Thanks for the PR.

@Dnouv Dnouv merged commit 7710c1e into RocketChat:main Jan 3, 2023
@Dnouv
Copy link
Member

Dnouv commented Jan 3, 2023

Congratulations on the first PR, @ayush3160 ! 🎉

Dnouv pushed a commit that referenced this pull request Sep 10, 2024
@ayush3160
Edit Event Feature Added In Admin Dashboard (#69)
5129047 
* Edit Event Feature Added

* Added Event Form And Edit For Tickets

* Image Link Edit Option

* UI changes for tabs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dnouv Dnouv Dnouv requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayush3160 @Dnouv