Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Add Background Audio Playback support #2712

Closed
wants to merge 1 commit into from
Closed

[IMPROVEMENT] Add Background Audio Playback support #2712

wants to merge 1 commit into from

Conversation

pratyaksh123
Copy link

@pratyaksh123 pratyaksh123 commented Dec 14, 2020 •
edited
Loading

Proposed changes

Solves #2578

Issue(s)

How to test or reproduce

  • Play an audio

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

  • To be tested on iOS

@pratyaksh123
Copy link
Author

@diegolmello Can you review the changes

@diegolmello
Copy link
Member

Hey, @pratyaksh123.
Thanks for your contribution.
I'll see if we can make it for 4.14.0 next year.

@diegolmello
Copy link
Member

@pratyaksh123 First of all, behave.
We're short on hands and we don't need to read this kind of comment rushing development from the community.
If this is something important to your company, whitelabel docs are there for you.

That said, 4.14.0 isn't out yet and I'm reviewing PRs to cut a new beta today.

diegolmello
diegolmello requested changes Jan 20, 2021
View reviewed changes
ios/RocketChatRN/Info.plist
@@ -89,6 +89,7 @@
</dict>
<key>UIBackgroundModes</key>
<array>
<string>audio</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this on iOS?

Copy link
Author

@pratyaksh123 pratyaksh123 Jan 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I can't because I don't have a Mac : (
expo/expo#9363 This PR confirms it works for version ^8.3.0

package.json
@@ -55,7 +55,7 @@
"ejson": "2.2.0",
"eslint-config-airbnb": "^18.1.0",
"expo-apple-authentication": "^2.2.1",
"expo-av": "8.2.1",
"expo-av": "^8.2.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I upgraded it because 8.2.1 had some bugs with iOS background playback expo/expo#5472 (comment)

yarn.lock
version "8.2.1"
resolved "https://registry.yarnpkg.com/expo-av/-/expo-av-8.2.1.tgz#cab16a5f0766b84a7c2e05e04523cb73a0cd4e9b"
integrity sha512-p1W6ta5yFLsyUUB4bH/Bm2gz/KEleYWRYkF7PR3aYXjtTjMX9Ud1gwzEfbMJMKZRSlJydSzy/ieQT8CVatd68A==
expo-av@^8.2.1:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't be needed after you undo package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello diegolmello requested changes

Assignees
No one assigned
Labels
👍 improvement 🚨 needs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pratyaksh123 @diegolmello