Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDF filles appear upside down #15012

Closed
mikeaer opened this issue Jul 17, 2019 · 7 comments · Fixed by DiegoVV/Rocket.Chat#1
Closed

PDF filles appear upside down #15012

mikeaer opened this issue Jul 17, 2019 · 7 comments · Fixed by DiegoVV/Rocket.Chat#1
Labels
type: bug ui/ux
Milestone
3.3.0

Comments

@mikeaer
Copy link

mikeaer commented Jul 17, 2019

Description:

When I send an pdf files, in some cases, pdf preview appear upside down

Steps to reproduce:

  1. Drag&drop an pdf file

Expected behavior:

PDF preview appear normally

Actual behavior:

Server Setup Information:

  • Version of Rocket.Chat Server: 1.2.1
  • Operating System: CentOS
  • Deployment Method: tar
  • Number of Running Instances: 3
  • DB Replicaset Oplog: yes
  • NodeJS Version: 8.11.3
  • MongoDB Version: 3.6.9
@stleitner
Copy link
Contributor

We have the same problem on our server.

@ChrissW-R1
Copy link
Contributor

Same here. This is very annoying. The preview uses many space in a chat and could read from the most of our users.

@reetp reetp mentioned this issue Aug 15, 2019
Open
DiegoVV pushed a commit to DiegoVV/Rocket.Chat that referenced this issue Sep 16, 2019
Fixed problem with PDFs being previewed upside-down.
d661e2b 
Issue fixed: "PDF filles appear upside down RocketChat#15012"
When resizing the image, the width was being set as the height, on line 178. And on line 184, there was nothing being assigned to the height.
After setting width to width, and assigning the height to height, the thumbnail for a PDF is displayed properly.
This was made as part of the interview process for Front-End Developer.
This was referenced Sep 16, 2019
Merged
Closed
@rwhorton66
Copy link

Is there any update on this issue?

@engelgabriel engelgabriel modified the milestones: 3.2.0, 3.3.0 May 1, 2020
@engelgabriel
Copy link
Member

@mikeaer can you still replicate but on the open.rocket.chat server?

@aermike
Copy link

aermike commented May 2, 2020

On version3.0.11 this isssue apprear to be fixed

@ChrissW-R1
Copy link
Contributor

This error couldn't reproduced in version 3.2.0.

@rodrigok
Copy link
Member

I'll close this since we can't reproduce the issue anymore. Please open a new issue if it still persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug ui/ux
Projects
None yet
Milestone
3.3.0
8 participants
@rodrigok @engelgabriel @ChrissW-R1 @tassoevan @aermike @mikeaer @stleitner @rwhorton66