Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove Users from fibers 13 #28772

Merged
merged 2 commits into from Apr 3, 2023

Conversation

MarcosSpessatto
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@MarcosSpessatto MarcosSpessatto self-assigned this Apr 3, 2023
@MarcosSpessatto MarcosSpessatto requested review from a team as code owners April 3, 2023 15:31
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #28772 (37c9869) into develop (3129e8b) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28772      +/-   ##
===========================================
+ Coverage    45.27%   45.30%   +0.03%     
===========================================
  Files          727      728       +1     
  Lines        14287    14291       +4     
  Branches      2216     2215       -1     
===========================================
+ Hits          6468     6475       +7     
+ Misses        7515     7509       -6     
- Partials       304      307       +3     
Flag Coverage Δ
e2e 45.26% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit 80bd6f0 into develop Apr 3, 2023
34 checks passed
@ggazzo ggazzo deleted the refactor/remove-fibers-from-users-13 branch April 3, 2023 20:26
gabriellsh added a commit that referenced this pull request Apr 4, 2023
…avatarEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat: (63 commits)
  fix: Messages jumping after reaction (#28770)
  fix: Quotes chain off by one error in quote chain limit settings (#28281)
  docs: update documentation (#28719)
  chore: /help notifying the shortcuts in multiple messages (#28765)
  refactor: remove Users from fibers 14 (#28780)
  regression(file-upload:s3): Fix missing store import (#28781)
  refactor: remove Users from fibers 13 (#28772)
  refactor: remove Users from fibers 12 (#28767)
  ci: revert Variable Setup changes (#28754)
  feat: auto link custom domain (#28501)
  refactor: `Rooms` model 4/4 (#28742)
  regression: invalid callback callAsync (#28766)
  refactor: remove Users from fibers 11 (#28740)
  refactor: Convert our Upload Code to TS (#28711)
  refactor: Move callbacks to ts 1X (#28710)
  refactor: Remove Users from fibers 10 (#28737)
  fix: message-parser links (#28735)
  refactor(client): Miscelaneous (#28732)
  refactor: `Rooms` model 3/4 (#28736)
  refactor: `Rooms` model 2X (#28715)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants