Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client): Miscelaneous #28732

Merged
merged 8 commits into from Apr 1, 2023
Merged

refactor(client): Miscelaneous #28732

merged 8 commits into from Apr 1, 2023

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan added this to the 6.2.0 milestone Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #28732 (f6bce40) into develop (1aad44b) will decrease coverage by 0.08%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28732      +/-   ##
===========================================
- Coverage    45.25%   45.18%   -0.08%     
===========================================
  Files          738      727      -11     
  Lines        14461    14286     -175     
  Branches      2236     2214      -22     
===========================================
- Hits          6545     6455      -90     
+ Misses        7611     7527      -84     
+ Partials       305      304       -1     
Flag Coverage Δ
e2e 45.14% <80.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the refactor/client-misc branch 2 times, most recently from ee317ae to f6bce40 Compare March 31, 2023 18:37
@tassoevan tassoevan marked this pull request as ready for review March 31, 2023 19:54
@tassoevan tassoevan requested review from a team as code owners March 31, 2023 19:54
@ggazzo ggazzo merged commit 400b31e into develop Apr 1, 2023
34 checks passed
@ggazzo ggazzo deleted the refactor/client-misc branch April 1, 2023 14:15
@hugocostadev hugocostadev mentioned this pull request Apr 2, 2023
gabriellsh added a commit that referenced this pull request Apr 4, 2023
…avatarEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat: (63 commits)
  fix: Messages jumping after reaction (#28770)
  fix: Quotes chain off by one error in quote chain limit settings (#28281)
  docs: update documentation (#28719)
  chore: /help notifying the shortcuts in multiple messages (#28765)
  refactor: remove Users from fibers 14 (#28780)
  regression(file-upload:s3): Fix missing store import (#28781)
  refactor: remove Users from fibers 13 (#28772)
  refactor: remove Users from fibers 12 (#28767)
  ci: revert Variable Setup changes (#28754)
  feat: auto link custom domain (#28501)
  refactor: `Rooms` model 4/4 (#28742)
  regression: invalid callback callAsync (#28766)
  refactor: remove Users from fibers 11 (#28740)
  refactor: Convert our Upload Code to TS (#28711)
  refactor: Move callbacks to ts 1X (#28710)
  refactor: Remove Users from fibers 10 (#28737)
  fix: message-parser links (#28735)
  refactor(client): Miscelaneous (#28732)
  refactor: `Rooms` model 3/4 (#28736)
  refactor: `Rooms` model 2X (#28715)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants