Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: /help notifying the shortcuts in multiple messages #28765

Merged
merged 5 commits into from Apr 4, 2023

Conversation

chinma-yyy
Copy link
Contributor

Proposed changes (including videos or screenshots)

Before

rcat

After

image

Issue(s)

closes #28763

Steps to test or reproduce

  1. use /help in any room

Further comments

@chinma-yyy
Copy link
Contributor Author

Hey @hugocostadev what changes do i need to make for the failing test?

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #28765 (3ff559f) into develop (49cd9da) will decrease coverage by 7.59%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28765      +/-   ##
===========================================
- Coverage    45.40%   37.81%   -7.59%     
===========================================
  Files          726      694      -32     
  Lines        14279    13959     -320     
  Branches      2213     2156      -57     
===========================================
- Hits          6483     5279    -1204     
- Misses        7489     8404     +915     
+ Partials       307      276      -31     
Flag Coverage Δ
e2e 37.81% <ø> (-7.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@hugocostadev hugocostadev added the stat: ready to merge PR tested and approved waiting for merge label Apr 4, 2023
@kodiakhq kodiakhq bot merged commit b25610c into RocketChat:develop Apr 4, 2023
32 of 33 checks passed
gabriellsh added a commit that referenced this pull request Apr 4, 2023
…avatarEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat: (63 commits)
  fix: Messages jumping after reaction (#28770)
  fix: Quotes chain off by one error in quote chain limit settings (#28281)
  docs: update documentation (#28719)
  chore: /help notifying the shortcuts in multiple messages (#28765)
  refactor: remove Users from fibers 14 (#28780)
  regression(file-upload:s3): Fix missing store import (#28781)
  refactor: remove Users from fibers 13 (#28772)
  refactor: remove Users from fibers 12 (#28767)
  ci: revert Variable Setup changes (#28754)
  feat: auto link custom domain (#28501)
  refactor: `Rooms` model 4/4 (#28742)
  regression: invalid callback callAsync (#28766)
  refactor: remove Users from fibers 11 (#28740)
  refactor: Convert our Upload Code to TS (#28711)
  refactor: Move callbacks to ts 1X (#28710)
  refactor: Remove Users from fibers 10 (#28737)
  fix: message-parser links (#28735)
  refactor(client): Miscelaneous (#28732)
  refactor: `Rooms` model 3/4 (#28736)
  refactor: `Rooms` model 2X (#28715)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/help notifying the shortcuts in multiple messages
2 participants