New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto link custom domain #28501
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #28501 +/- ##
===========================================
+ Coverage 45.33% 45.37% +0.04%
===========================================
Files 727 728 +1
Lines 14285 14293 +8
Branches 2215 2216 +1
===========================================
+ Hits 6476 6486 +10
+ Misses 7505 7496 -9
- Partials 304 311 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Guilherme Jun Grillo <48109548+guijun13@users.noreply.github.com>
…avatarEmoji * 'develop' of github.com:RocketChat/Rocket.Chat: (63 commits) fix: Messages jumping after reaction (#28770) fix: Quotes chain off by one error in quote chain limit settings (#28281) docs: update documentation (#28719) chore: /help notifying the shortcuts in multiple messages (#28765) refactor: remove Users from fibers 14 (#28780) regression(file-upload:s3): Fix missing store import (#28781) refactor: remove Users from fibers 13 (#28772) refactor: remove Users from fibers 12 (#28767) ci: revert Variable Setup changes (#28754) feat: auto link custom domain (#28501) refactor: `Rooms` model 4/4 (#28742) regression: invalid callback callAsync (#28766) refactor: remove Users from fibers 11 (#28740) refactor: Convert our Upload Code to TS (#28711) refactor: Move callbacks to ts 1X (#28710) refactor: Remove Users from fibers 10 (#28737) fix: message-parser links (#28735) refactor(client): Miscelaneous (#28732) refactor: `Rooms` model 3/4 (#28736) refactor: `Rooms` model 2X (#28715) ...
@hugocostadev hey! When do you plan to land that fix to new release? |
Hey @ankar84 this is scheduled for v 6.2.0. It's already in the release-candidate. |
Thank you @marceloschmidt |
Proposed changes (including videos or screenshots)
Changes:
/admin/settings/Message
Options
useAutoLinkDomains
to get the setting and return an array of domainsCurrent:
Desirable:
Output when the setting has the value:
local,intranet
New setting:
Issue(s)
fix #28427
Steps to test or reproduce
{{client_url}}/admin/settings/Message
Custom Domain Whitelist for Auto Link
intranet
Here it is the link for our https://internaltool.intranet
Further comments
This PR is related with: RocketChat/fuselage#1010
TC-557