Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: revert Variable Setup changes #28754

Merged
merged 1 commit into from Apr 3, 2023
Merged

ci: revert Variable Setup changes #28754

merged 1 commit into from Apr 3, 2023

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Apr 2, 2023

Proposed changes (including videos or screenshots)

Due to a change in Variable Setup action, external contributors PR fails because the branch reference is not found, revert will make to use the default branch as reference

Issue(s)

Steps to test or reproduce

Further comments

@hugocostadev hugocostadev requested a review from a team as a code owner April 2, 2023 17:57
@hugocostadev hugocostadev changed the title ci: revert Variable Check changes ci: revert Variable Setup changes Apr 2, 2023
@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Merging #28754 (f0de3c5) into develop (3129e8b) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28754      +/-   ##
===========================================
+ Coverage    45.27%   45.33%   +0.06%     
===========================================
  Files          727      727              
  Lines        14287    14287              
  Branches      2216     2216              
===========================================
+ Hits          6468     6477       +9     
+ Misses        7515     7506       -9     
  Partials       304      304              
Flag Coverage Δ
e2e 45.29% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit 159eb73 into develop Apr 3, 2023
37 checks passed
@ggazzo ggazzo deleted the ci-varibles branch April 3, 2023 20:06
gabriellsh added a commit that referenced this pull request Apr 4, 2023
…avatarEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat: (63 commits)
  fix: Messages jumping after reaction (#28770)
  fix: Quotes chain off by one error in quote chain limit settings (#28281)
  docs: update documentation (#28719)
  chore: /help notifying the shortcuts in multiple messages (#28765)
  refactor: remove Users from fibers 14 (#28780)
  regression(file-upload:s3): Fix missing store import (#28781)
  refactor: remove Users from fibers 13 (#28772)
  refactor: remove Users from fibers 12 (#28767)
  ci: revert Variable Setup changes (#28754)
  feat: auto link custom domain (#28501)
  refactor: `Rooms` model 4/4 (#28742)
  regression: invalid callback callAsync (#28766)
  refactor: remove Users from fibers 11 (#28740)
  refactor: Convert our Upload Code to TS (#28711)
  refactor: Move callbacks to ts 1X (#28710)
  refactor: Remove Users from fibers 10 (#28737)
  fix: message-parser links (#28735)
  refactor(client): Miscelaneous (#28732)
  refactor: `Rooms` model 3/4 (#28736)
  refactor: `Rooms` model 2X (#28715)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants