Banner notification is not undone

[wanderlage]

Description:

After updating to version 6.5.4 the banners are not disappearing.
You click close and nothing happens.

Expected behavior:

Click the close button on the banner and it will disappear.

Actual behavior:

Server Setup Information:

• Version of Rocket.Chat Server: 6.5.4
• Operating System:
• Deployment Method: docker
• Number of Running Instances: 1
• NodeJS Version: v14.21.3
• MongoDB Version: 6.0.10 / wiredTiger (oplog Enabled)

Client Setup Information

• Desktop App or Browser Version:
• Operating System:

Additional context

Analyzing the rocketchat_banner_dismiss collection in the database, we can see that it updated the table, but the application did not consider it.

db.getCollection("rocketchat_banner_dismiss").find({})

{
    "_id" : "65f82df54ff1b90ee957618d",
    "userId" : "ayywxy79Zay3AbGfa",
    "bannerId" : "65f81986b42c4ec42d29bc98",
    "dismissedBy" : {
        "_id" : "ayywxy79Zay3AbGfa",
        "username" : "wander.silva"
    },
    "dismissedAt" : ISODate("2024-03-18T12:05:09.209+0000"),
    "_updatedAt" : ISODate("2024-03-18T12:05:09.210+0000")
}

When clicking to close the notification, the error below is displayed in the server log.

Relevant logs:

{"level":50,"time":"2024-03-18T15:02:14.485Z","pid":1,"hostname":"rocketchat-rocketchat-6dd4f946fd-9dxhw","name":"System","err":{"type":"CloudWorkspaceConnectionError","message":"Failed to connect to Rocket.Chat Cloud: undefined","stack":"CloudWorkspaceConnectionError: Failed to connect to Rocket.Chat Cloud: undefined<br>    at server/modules/core-apps/cloudAnnouncements.module.ts:255:10<br>    at /app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40<br> => awaited here:<br>    at Function.Promise.await (/app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:56:12)<br>    at server/modules/core-apps/cloudAnnouncements.module.ts:86:27<br>    at /app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40","name":"CloudWorkspaceConnectionError"},"msg":"Failed to connect to Rocket.Chat Cloud: undefined"} 

[danielfariati]

We were also having this problem with version 6.5.
Tried updating to the latest version (6.6.3), to see if it would fix it, but the problem still persists.

Also, those banners are causing huge performance problems already in 6.5, when loaded (huge browser / app freezes)...
After updating to 6.6.3 it was even worse, because it caused the app to be completely unusable to our admins (browser crashes + infinite loading)...
More info (including workarounds) on issue #31893

[Ritesh92A]

I fully understood this issue and wanted to solve it so please Assign this issue to me.

[Visbhavesh]

I wanted to work in thus issue please Assign this issue to me.

[luizjr]

It takes a long time to resolve it, given that there are already people willing to resolve it. This problem has a very negative impact on the Rocketchat user experience.

[reetp]

It takes a long time to resolve it, given that there are already people willing to resolve it. This problem has a very negative impact on the Rocketchat user experience.

There is a very long process involved in getting items fixed. It has to go through a number of stages and it competes with separate issues raised directly by (paying) Enterprise customers along with the requirements of various other teams.

If people want to fix it and add PRs then they can go right ahead but no one gets 'assigned' anything.

Can the OP or anyone else confirm if this is still an issue?

[ep518]

Can confirm still having this issue. Persistent banner that does not get dismissed. I've removed the element via custom CSS for now but obviously not a permanent solution.

[reetp]

Can confirm still having this issue. Persistent banner that does not get dismissed. I've removed the element via custom CSS for now but obviously not a permanent solution.

Doing 'Me too' doesn't help as your situation may have a totally different cause from the OP.

Please fill out the Server setup and Client setup details from the bug template so we can see what you are running.

Note you should be testing this on minimum 6.8.0 or 6.9.0

Please also include the error messages from your log as per the OP.

Thanks.

[ChetanGoti]

We are on 6.9.0 and can confirm this issue still exists.

When I click on the X button of this message, it throws following error in server logs:

rocketchat_1 | {"level":50,"time":"2024-06-10T11:35:55.061Z","pid":9,"hostname":"9559ad42498f","name":"System","err":{"type":"CloudWorkspaceConnectionError","message":"Failed to connect to Rocket.Chat Cloud: undefined","stack":"CloudWorkspaceConnectionError: Failed to connect to Rocket.Chat Cloud: undefined\n at server/modules/core-apps/cloudAnnouncements.module.ts:256:10\n at /app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40\n => awaited here:\n at Function.Promise.await (/app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:56:12)\n at server/modules/core-apps/cloudAnnouncements.module.ts:87:27\n at /app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40","name":"CloudWorkspaceConnectionError"},"msg":"Failed to connect to Rocket.Chat Cloud: undefined"}

Deployment information

Deployment

Version
6.9.0

Deployment ID
REDACTED

Cloud Workspace ID
REDACTED

Apps Engine Version
1.42.2

Node Version
v14.21.3

Database Migration
304 (June 10, 2024 5:05 PM)

MongoDB
5.0.21 / wiredTiger (oplog Disabled)

Commit Details
HEAD: (3b820dcd2)
Branch: HEAD
Release 6.9.0

PID
9

[reetp]

I believe this might help fix some of these issues.

#32552

Probably in 6.10

[Gustrb]

We probably shouldn't be returning error: undefined as well, I will talk with the team so we can fix that :)

[Gustrb]

#32552 was merged so this will land on 6.10 😁
If the issue persists after the release please comment about it here