Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Rest endpoints of discussions #13987

Merged
merged 18 commits into from
Apr 11, 2019
Merged

[NEW] Rest endpoints of discussions #13987

merged 18 commits into from
Apr 11, 2019

Conversation

MarcosSpessatto
Copy link
Member

Closes #13973

app/api/server/v1/rooms.js Outdated Show resolved Hide resolved
@rodrigok rodrigok requested a review from ggazzo April 3, 2019 12:50
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13987 April 6, 2019 00:29 Inactive
@engelgabriel
Copy link
Member

Can we please keep consistency between DDP and REST API calls?

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13987 April 6, 2019 01:02 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13987 April 6, 2019 01:55 Inactive
@rodrigok
Copy link
Member

rodrigok commented Apr 6, 2019

@ggazzo @rafaelks @engelgabriel is necessary to have a endpoint to list discussions? Aren't they part of rooms?

@rodrigok rodrigok temporarily deployed to rocket-chat-pr-13987 April 6, 2019 14:31 Inactive
@rafaelks
Copy link
Contributor

rafaelks commented Apr 7, 2019

@rodrigok Yes, you can be a non member of a discussion but still want to access it.

@rodrigok
Copy link
Member

rodrigok commented Apr 7, 2019

@rafaelks ok, so then explain how this endpoint would be used. Where are you planing to list the discussions of a single room?

@rafaelks
Copy link
Contributor

rafaelks commented Apr 7, 2019

@rodrigok Like the web client, the mobile apps could display all discussions of a Room, similar to Attachments, Pinned, Starred, etc. What do you think?

@rodrigok
Copy link
Member

rodrigok commented Apr 7, 2019

@rafaelks ah, ok, sure, didn't remember we had a place to list discussions of a single room, it makes sense now.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13987 April 7, 2019 20:42 Inactive
@engelgabriel
Copy link
Member

@rafaelks is correct, we have this on the web, the user can use the sidebar to see all discussions of a room

@rodrigok rodrigok self-assigned this Apr 7, 2019
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-13987 April 8, 2019 20:48 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-13987 April 8, 2019 23:33 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-13987 April 10, 2019 13:45 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13987 April 10, 2019 20:20 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-13987 April 10, 2019 21:54 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13987 April 11, 2019 14:05 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13987 April 11, 2019 14:06 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13987 April 11, 2019 18:00 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants