Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] adjustments for tooltips to show room name instead of id #14084

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

mohamedar97
Copy link
Contributor

Closes #14083

@knrt10
Copy link
Contributor

knrt10 commented Apr 11, 2019

@mohamedar97 I saw that you are creating different PRs for same type of issue. What you could have done is create a one PR will all the changes. It would be helpful for others to manage when merging. Now don't change it, from next time remember it because it would be helpful for you too to manage one PR than many with same kind of solution. Hope this helps, thanks

@mohamedar97
Copy link
Contributor Author

i'm thought this how things work here so i created different PRs. if i delete two of the 3 PRs and commit all of the changes to the initial PR would that be better?

@knrt10
Copy link
Contributor

knrt10 commented Apr 11, 2019

It’s ok, don’t worry now. Also don't take my above comment in the wrong way, just helping you out. It’s for future reference. 🙂

@mohamedar97
Copy link
Contributor Author

absolutely not. i really appreciate how tolerant you are with me since i started contributing to RC

1 similar comment
@mohamedar97
Copy link
Contributor Author

absolutely not. i really appreciate how tolerant you are with me since i started contributing to RC

@knrt10
Copy link
Contributor

knrt10 commented Apr 11, 2019

That’s what Open source community is for. You learn and help others learn 🤟🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] tooltips show room id in discussions
3 participants