Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into develop & Set version to 2.2.0-develop #15622

Merged
merged 2 commits into from
Oct 20, 2019
Merged

Conversation

rodrigok
Copy link
Member

No description provided.

* [FIX] dynamic import  (#15598)

* [FIX] Read Recepts was not working (#15603)

* Bump version to 2.1.1
@rodrigok rodrigok merged commit 7ef5395 into develop Oct 20, 2019
@rodrigok rodrigok deleted the develop-sync branch October 20, 2019 21:37
@bkraul
Copy link

bkraul commented Oct 20, 2019

So hey, what's with this commit? Is it safe to use in the develop image? I notice it says it is Release 2.1.1. Later it says that it bumps to 2.2.0-develop but there is nothing in any of the changed files that reflects this:

image

Then again, maybe I am not understanding how develop syncs work? My concern is a version regression.

@rodrigok
Copy link
Member Author

@bkraul we don't do tags while in develop, so the tag will always point to the latest stable release on develop branch.

We released 2.2.0-rc.0 yesterday, so I had to merge our 2.1.1 release back to develop (because we released it using cherry-picks) to prevent merge conflicts (since both branches had the same changes) to then create the release candidate for 2.2.0.

@rodrigok rodrigok mentioned this pull request Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants