Fix github actions accessing the github registry #16521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
rodrigok
approved these changes
Feb 14, 2020
Merged
gabriellsh
added a commit
that referenced
this pull request
Feb 18, 2020
…pinned_messages_collapse * 'develop' of github.com:RocketChat/Rocket.Chat: (90 commits) [FIX] livechat/rooms endpoint not working with big amount of livechats (#16623) [FIX] Regression: Jitsi on external window infinite loop (#16625) [FIX] UiKit not updating new actionIds received as responses from actions (#16624) Bump version to 3.1.0-develop Bump version to 3.0.0 Bump version to 3.0.0-rc.11 Fix enter behavior send file on enter Fix github actions accessing the github registry (#16521) Bump version to 3.0.0-rc.10 [FIX] Bug on starting Jitsi video calls , multiple messages (#16601) Bump version to 3.0.0-rc.9 Regression: fix read unread messages (#16562) Regression: UIKit update modal actions (#16570) fixed duplicated toastrs (#16578) Update Livechat widget dependency version to 1.3.1. (#16580) Update Apps-Engine version (#16584) [FIX] Error when successfully joining room by invite link (#16571) Add breaking notice regarding TLS (#16575) [FIX] Invite links proxy URLs not working when using CDN (#16581) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building PR images, the docker authentication fails once an organization (and not an individual user) is creating the PR, see https://github.com/assistify/Rocket.Chat/runs/431633181
Reason
The docker login needs to use credentials matching
GITHUB_TOKENAfter the fix
https://github.com/assistify/Rocket.Chat/runs/432851281